From: Antti Palosaari <crope@iki.fi>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 7/7] af9013 empty buffer overflow command.
Date: Sat, 12 Nov 2011 18:55:34 +0200 [thread overview]
Message-ID: <4EBEA506.3030003@iki.fi> (raw)
In-Reply-To: <4ebe9734.d4c7e30a.6b0e.ffff9414@mx.google.com>
On 11/12/2011 05:56 PM, Malcolm Priestley wrote:
> This command is present in other Afatech devices zeroing bit 7
> seems to force streaming output even if it isn't one.
>
> I was considering timing it out, but it seems to have no harmful effect
> on streaming output.
You didn't find any reason this makes sense?
regards
Antti
>
> Signed-off-by: Malcolm Priestley<tvboxspy@gmail.com>
> ---
> drivers/media/dvb/frontends/af9013.c | 5 ++++-
> 1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/dvb/frontends/af9013.c b/drivers/media/dvb/frontends/af9013.c
> index 6a5b40c..fbf6bca 100644
> --- a/drivers/media/dvb/frontends/af9013.c
> +++ b/drivers/media/dvb/frontends/af9013.c
> @@ -1094,7 +1094,10 @@ static int af9013_read_status(struct dvb_frontend *fe, fe_status_t *status)
> }
>
> ret = af9013_update_statistics(fe);
> -
> + if (ret)
> + goto error;
> + /* Force empty stream buffer if overflow */
> + ret = af9013_write_reg_bits(state, 0xd500, 7, 1, 0);
> error:
> return ret;
> }
--
http://palosaari.fi/
prev parent reply other threads:[~2011-11-12 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 15:56 [PATCH 7/7] af9013 empty buffer overflow command Malcolm Priestley
2011-11-12 16:55 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBEA506.3030003@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox