From: Antti Palosaari <crope@iki.fi>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 0/7] af9015 dual tuner and othe fixes from my builds.
Date: Sat, 12 Nov 2011 18:59:31 +0200 [thread overview]
Message-ID: <4EBEA5F3.1050103@iki.fi> (raw)
In-Reply-To: <4EBE9AA6.8090500@iki.fi>
On 11/12/2011 06:11 PM, Antti Palosaari wrote:
> On 11/12/2011 05:57 PM, Malcolm Priestley wrote:
>> Here is the lastest patches, for dual tuner and other fixes on the
>> patchwork server.
>>
>>
>> Malcolm Priestley (7):
>> af9015 Slow down download firmware
>> af9015 Remove call to get config from probe.
>> af9015/af9013 full pid filtering.
>> af9013 frontend tuner bus lock and gate changes v2
>> af9015 bus repeater
>> af9013 Stop OFSM while channel changing.
>> af9013 empty buffer overflow command.
>>
>> drivers/media/dvb/dvb-usb/af9015.c | 220
>> +++++++++++++++++++++-------------
>> drivers/media/dvb/frontends/af9013.c | 18 +++-
>> drivers/media/dvb/frontends/af9013.h | 5 +-
>> 3 files changed, 158 insertions(+), 85 deletions(-)
>
> Uhhuh, you have done rather much changes. Are you really sure those all
> are needed and OK ?
>
> I think the issues are stream corruption and I2C some write fails. As I
> did some tests earlier it looked like I2C writes happens to fail when
> you program tuner and it is interrupted by some other command (read_snr,
> read_status, etc.).
I looked those just through and I want more information about every
patch. Mainly I want to know which resolves which problem. As far as I
understand, there is two problems;
1. register access fails sometimes (as I suspect in case of access some
registers when firmware is programming tuner or doing some other task
and does not expect it is interrupted)
2. stream corruptions
Is that possible you identify which changes fix 1 and what are for 2?
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-11-12 16:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 15:57 [PATCH 0/7] af9015 dual tuner and othe fixes from my builds Malcolm Priestley
2011-11-12 16:11 ` Antti Palosaari
2011-11-12 16:59 ` Antti Palosaari [this message]
2011-11-13 1:53 ` Antti Palosaari
2011-11-14 16:34 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBEA5F3.1050103@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox