From: Antti Palosaari <crope@iki.fi>
To: Malcolm Priestley <tvboxspy@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/7] af9015 Remove call to get config from probe.
Date: Sun, 13 Nov 2011 14:34:10 +0200 [thread overview]
Message-ID: <4EBFB942.1030900@iki.fi> (raw)
In-Reply-To: <4ebfb241.8366b40a.1a27.7902@mx.google.com>
On 11/13/2011 02:04 PM, Malcolm Priestley wrote:
> On Sat, 2011-11-12 at 21:36 +0200, Antti Palosaari wrote:
>> On 11/12/2011 08:22 PM, Malcolm Priestley wrote:
>>> On Sat, 2011-11-12 at 18:18 +0200, Antti Palosaari wrote:
>>>> On 11/12/2011 05:55 PM, Malcolm Priestley wrote:
>>>>> Remove get config from probe and move to identify_state.
>>>>>
>>>>> intf->cur_altsetting->desc.bInterfaceNumber is always expected to be zero, so there
>>>>> no point in checking for it.
>>>>
>>>> Are you sure? IIRC there is HID remote on interface 1 or 2 or so (some
>>>> other than 0). Please double check.
>>>>
>>>>> Calling from probe seems to cause a race condition with some USB controllers.
>>>>
>>>> Why?
>>>>
>>> Is some other module going to claim the device?
>>>
>>> Would it not be better use usb_set_interface to set it back to 0?
>>>
>
> I spoke too soon, there is someone else about.
>
> On boot input claims interface 1
>
> Nov 13 11:43:36 tvbox kernel: [ 1.830276] input: Afatech DVB-T 2 as /devices/pci0000:00/0000:00:06.1/usb2/2-4/2-4:1.1/input/input2
> Nov 13 11:43:36 tvbox kernel: [ 1.830367] generic-usb 0003:1B80:E399.0001: input,hidraw0: USB HID v1.01 Keyboard [Afatech DVB-T 2] on usb-0000:00:06.1-4/input1
> ...
> Nov 13 11:43:38 tvbox kernel: [ 19.151700] dvb-usb: found a 'KWorld PlusTV Dual DVB-T Stick (DVB-T 399U)' in cold state, will try to load a firmware
> ...
> Nov 13 11:43:39 tvbox kernel: [ 20.313483] input: IR-receiver inside an USB DVB receiver as /devices/pci0000:00/0000:00:06.1/usb2/2-4/rc/rc0/input8
> Nov 13 11:43:39 tvbox kernel: [ 20.313528] rc0: IR-receiver inside an USB DVB receiver as /devices/pci0000:00/0000:00:06.1/usb2/2-4/rc/rc0
> Nov 13 11:43:39 tvbox kernel: [ 20.313530] dvb-usb: schedule remote query interval to 500 msecs.
> Nov 13 11:43:39 tvbox kernel: [ 20.313534] dvb-usb: KWorld PlusTV Dual DVB-T Stick (DVB-T 399U) successfully initialized and connected.
>
> So, a usb_set_interface is needed to make sure we on interface 0 and remain there.
Sorry, didn't still understand what you mean.
What I would like to say check for interface was set for HID remote and
since we just want to leave HID without any driver help we will just
skip it.
Do you try to say it should be always set usb_set_interface 0 just for sure?
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2011-11-13 12:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 15:55 [PATCH 2/7] af9015 Remove call to get config from probe Malcolm Priestley
2011-11-12 16:18 ` Antti Palosaari
2011-11-12 18:22 ` Malcolm Priestley
2011-11-12 19:36 ` Antti Palosaari
2011-11-13 12:04 ` Malcolm Priestley
2011-11-13 12:34 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBFB942.1030900@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox