From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bw0-f46.google.com ([209.85.214.46]:64274 "EHLO mail-bw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754606Ab1KOKlL (ORCPT ); Tue, 15 Nov 2011 05:41:11 -0500 Received: by bke11 with SMTP id 11so6980013bke.19 for ; Tue, 15 Nov 2011 02:41:09 -0800 (PST) Message-ID: <4EC24190.9010005@mvista.com> Date: Tue, 15 Nov 2011 14:40:16 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Manjunath Hadli CC: LMML , dlos , LAK Subject: Re: [PATCH v2 1/5] davinci: dm644x: remove the macros from the header to move to c file References: <1321283357-27698-1-git-send-email-manjunath.hadli@ti.com> <1321283357-27698-2-git-send-email-manjunath.hadli@ti.com> In-Reply-To: <1321283357-27698-2-git-send-email-manjunath.hadli@ti.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hello. On 14-11-2011 19:09, Manjunath Hadli wrote: > move the register base addresses and offsets used only by dm644x > platform file from platform header dm644x.h to dm644x.c as they > are used only in the c file. > Signed-off-by: Manjunath Hadli > --- > arch/arm/mach-davinci/dm644x.c | 6 ++++++ > arch/arm/mach-davinci/include/mach/dm644x.h | 7 ------- > 2 files changed, 6 insertions(+), 7 deletions(-) > diff --git a/arch/arm/mach-davinci/dm644x.c b/arch/arm/mach-davinci/dm644x.c > index 3470983..1b4b911 100644 > --- a/arch/arm/mach-davinci/dm644x.c > +++ b/arch/arm/mach-davinci/dm644x.c > @@ -34,6 +34,12 @@ > * Device specific clocks > */ > #define DM644X_REF_FREQ 27000000 Add an empty line here please. > +#define DM644X_EMAC_BASE 0x01c80000 > +#define DM644X_EMAC_MDIO_BASE (DM644X_EMAC_BASE + 0x4000) > +#define DM644X_EMAC_CNTRL_OFFSET 0x0000 > +#define DM644X_EMAC_CNTRL_MOD_OFFSET 0x1000 > +#define DM644X_EMAC_CNTRL_RAM_OFFSET 0x2000 > +#define DM644X_EMAC_CNTRL_RAM_SIZE 0x2000 > > static struct pll_data pll1_data = { > .num = 1, WBR, Sergei