From: Sergei Shtylyov <sshtylyov@mvista.com>
To: Manjunath Hadli <manjunath.hadli@ti.com>
Cc: LMML <linux-media@vger.kernel.org>,
dlos <davinci-linux-open-source@linux.davincidsp.com>,
LAK <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 5/5] davinci: delete individual platform header files and use a common header
Date: Tue, 15 Nov 2011 14:54:49 +0400 [thread overview]
Message-ID: <4EC244F9.1030604@mvista.com> (raw)
In-Reply-To: <1321283357-27698-6-git-send-email-manjunath.hadli@ti.com>
Hello.
On 14-11-2011 19:09, Manjunath Hadli wrote:
> include davinci_common.h file in files using the platform
> header file for dm355, dm365, dm644x and dm646x and delete the
> individual platform header files.
> Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com>
[...]
> diff --git a/drivers/media/video/davinci/vpif.h b/drivers/media/video/davinci/vpif.h
> index 25036cb..73b00bd 100644
> --- a/drivers/media/video/davinci/vpif.h
> +++ b/drivers/media/video/davinci/vpif.h
> @@ -18,8 +18,7 @@
>
> #include<linux/io.h>
> #include<linux/videodev2.h>
> -#include<mach/hardware.h>
Why are you removing this?
> -#include<mach/dm646x.h>
> +#include<mach/davinci_common.h>
> #include<media/davinci/vpif_types.h>
>
> /* Maximum channel allowed */
> diff --git a/drivers/media/video/davinci/vpif_capture.h b/drivers/media/video/davinci/vpif_capture.h
> index a693d4e..c019d26 100644
> --- a/drivers/media/video/davinci/vpif_capture.h
> +++ b/drivers/media/video/davinci/vpif_capture.h
> @@ -27,6 +27,7 @@
> #include<media/v4l2-device.h>
> #include<media/videobuf-core.h>
> #include<media/videobuf-dma-contig.h>
> +#include<mach/davinci_common.h>
Not clear why are you adding this when no platform header was included before.
WBR, Sergei
next prev parent reply other threads:[~2011-11-15 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-14 15:09 [PATCH v2 0/5] davinci: re-arrange definitions to have a common davinci header Manjunath Hadli
2011-11-14 15:09 ` [PATCH v2 1/5] davinci: dm644x: remove the macros from the header to move to c file Manjunath Hadli
2011-11-15 10:40 ` Sergei Shtylyov
2011-11-15 14:17 ` Hadli, Manjunath
2011-11-14 15:09 ` [PATCH v2 2/5] davinci: dm365: " Manjunath Hadli
2011-11-14 15:09 ` [PATCH v2 3/5] davinci: dm646x: " Manjunath Hadli
2011-11-14 15:09 ` [PATCH v2 4/5] davinci: create new common platform header for davinci Manjunath Hadli
2011-11-15 10:03 ` Sergei Shtylyov
2011-11-15 13:55 ` Hadli, Manjunath
2011-11-14 15:09 ` [PATCH v2 5/5] davinci: delete individual platform header files and use a common header Manjunath Hadli
2011-11-15 10:54 ` Sergei Shtylyov [this message]
2011-11-15 14:16 ` Hadli, Manjunath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC244F9.1030604@mvista.com \
--to=sshtylyov@mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=manjunath.hadli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox