From: Hans de Goede <hdegoede@redhat.com>
To: Ezequiel <elezegarcia@gmail.com>
Cc: linux-media@vger.kernel.org, elezegarcia@yahoo.com.ar, moinejf@free.fr
Subject: Re: [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release
Date: Sun, 20 Nov 2011 11:03:21 +0100 [thread overview]
Message-ID: <4EC8D069.1080204@redhat.com> (raw)
In-Reply-To: <20111119214621.GA2739@localhost>
Hi,
On 11/19/2011 10:46 PM, Ezequiel wrote:
> Pushed video_device initialization into a separate function.
> Replace static allocation of struct video_device by
> video_device_alloc/video_device_release usage.
>
NACK again! There is no reason to do this, it just makes
the code more complicated without gaining anything. As already
commented by Antonio Ospite your commit message lacks the why of
this patch / the reason to do such a patch. The diffstat clearly
shows it is adding code not removing / simplifying it and it
so doing so without any good reasons!
Regards,
Hans
next prev parent reply other threads:[~2011-11-20 10:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 21:46 [PATCH v2] [media] gspca: replaced static allocation by video_device_alloc/video_device_release Ezequiel
2011-11-19 22:48 ` Antonio Ospite
2011-11-20 10:03 ` Hans de Goede [this message]
2011-11-21 23:02 ` Ezequiel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC8D069.1080204@redhat.com \
--to=hdegoede@redhat.com \
--cc=elezegarcia@gmail.com \
--cc=elezegarcia@yahoo.com.ar \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox