From: Sakari Ailus <sakari.ailus@iki.fi>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: "Sylwester Nawrocki" <snjw23@gmail.com>,
linux-media <linux-media@vger.kernel.org>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Rémi Denis-Courmont" <remi@remlab.net>
Subject: Re: [Query] V4L2 Integer (?) menu control
Date: Thu, 24 Nov 2011 22:57:34 +0200 [thread overview]
Message-ID: <4ECEAFBE.1010303@iki.fi> (raw)
In-Reply-To: <4ECE0FA5.1040205@samsung.com>
Hi Sylwester,
Sylwester Nawrocki wrote:
> Thank you all for the comments.
>
> On 11/24/2011 09:50 AM, Sakari Ailus wrote:
>> Hi Sylwester,
>>
>> There is not currently, but I have patches for it. The issue is that I need
>> them myself but the driver I need them for isn't ready to be released yet.
>> And as usual, I assume others than vivo is required to show they're really
>> useful so I haven't sent them.
>
> That's great news. Then I might not need to do all the work on my own;)
I hope mine will do. ;-)
I'm working on 2.6.32 kernel (ouch!) so I haven't been able to test them
properly yet. Please provide feedback on them if you find any issues.
>>
>> Good that you asked so we won't end up writing essentially the same code
>> again. I'll try to send the patches today.
>
> All right, there is no rush. I was just looking around how to support the
> camera scene mode with m5mols sort of sensors. The scene mode is essentially
> a compilation of several different parameters, for some of which there are
> standard controls in V4L2 but for many there are not.
I fully agree with this approach. Scene modes should not be implemented
at the level of the V4L2 API. Instead, the parameters that the scene
modes consist of must be shown separately on the V4L2 API, if that is
the level of API they belong to. Depending on your camera stack control
algorithms could reside in the user space, which I believe is however
not the case with the M5-MOLS.
> I've got a feeling the best way to handle this would be to create controls
> for each single parameter and then do a batch set from user space, and keep
> the scene mode mappings in user space. The only concern is there is a couple
> of ISP-specific parameters involved with that scene mode thing. Perhaps they
> just could be set initially to fixed values.
Can you describe what kind of parameters this is about? Is there an
issue in just setting those using the ISP driver V4L2 subdev API?
This makes your user space to depend both on the sensor and the ISP, but
there's really no way around that if both do non-trivial
hardware-specific things.
I think we need to further standardise image processing configuration
such as RGB-to-RGB matrices and gamma tables. This would make the ISP
interfaces less hardware specific.
Kind regards,
--
Sakari Ailus
sakari.ailus@iki.fi
next prev parent reply other threads:[~2011-11-24 20:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 22:26 [Query] V4L2 Integer (?) menu control Sylwester Nawrocki
2011-11-24 6:24 ` Rémi Denis-Courmont
2011-11-24 9:17 ` Sylwester Nawrocki
2011-11-24 8:47 ` Hans Verkuil
2011-11-24 8:50 ` Sakari Ailus
2011-11-24 9:34 ` Sylwester Nawrocki
2011-11-24 20:57 ` Sakari Ailus [this message]
2011-11-24 23:53 ` Sylwester Nawrocki
2011-11-26 9:36 ` Sakari Ailus
2011-11-26 19:27 ` Sylwester Nawrocki
2011-12-12 21:08 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECEAFBE.1010303@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=remi@remlab.net \
--cc=s.nawrocki@samsung.com \
--cc=snjw23@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox