Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Jens Erdmann]

Hi folks,

just a few quetstions:
1. Why is the device named EM2884_BOARD_CINERGY_HTC_STICK and not
    EM2884_BOARD_TERRATEC_HTC_STICK like all the other devices from that
    vendor? Looks inconsistent to me.

2. I stumbled over http://linux.terratec.de/tv_en.html where they list a NXP TDA18271
    as used tuner for H5 and HTC Stick devices. I dont have any experience in this
    kind of stuff but i am just asking.

Regads,
  Jens
___________________________________________________________
SMS schreiben mit WEB.DE FreeMail - einfach, schnell und
kostenguenstig. Jetzt gleich testen! http://f.web.de/?mc=021192

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Antti Palosaari]

Hello

On 11/28/2011 05:41 PM, Jens Erdmann wrote:
> just a few quetstions:
> 1. Why is the device named EM2884_BOARD_CINERGY_HTC_STICK and not
>      EM2884_BOARD_TERRATEC_HTC_STICK like all the other devices from that
>      vendor? Looks inconsistent to me.

Developer have just chosen some value. Maybe he have not looked so 
carefully about naming. Feel free to fix :) I think correct name is 
something chip version + "board" + vendor name + device name and model. 
If name goes something like very long it could be shortened.

> 2. I stumbled over http://linux.terratec.de/tv_en.html where they list a NXP TDA18271
>      as used tuner for H5 and HTC Stick devices. I dont have any experience in this
>      kind of stuff but i am just asking.

DVB device contain logically three chips. Those are;
1. interface chip (USB, PCI)
2. demodulator
3. tuner

Those parts can be integrated even as one silicon (called 3-in-1). Very 
commonly it seen combination 1.+2. in one chip and 3. in other == total 
2 chips.

EM2884 is interface chip. It is called usually DVB USB bridge since it 
transfers bits from demod to computer.
TDA18271 is tuner. On the other side of chip is antenna connected as 
signal input and output is IF (intermediate frequency). Tuner can be 
thought as chip that transfers signal from RF (radio frequency) to IF 
(intermediate frequency). Demodulator then takes that IF from tuner and 
encodes bits out from signal. Interface between demodulator and bridge 
is bit interface and it is called MPEG2 TS (transport stream) interface.

There is also second interface for controlling each chip. That interface 
is usually I2C bus. Each chip (demod and tuner) is connected to the 
I2C-bus-adapter which is part of bridge. All command to chips are send 
using that I2C interface.

regards
Antti


-- 
http://palosaari.fi/

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Andreas Oberritter]

Hello Jens,

On 28.11.2011 16:41, Jens Erdmann wrote:
> Hi folks,
> 
> just a few quetstions:
> 1. Why is the device named EM2884_BOARD_CINERGY_HTC_STICK and not
>     EM2884_BOARD_TERRATEC_HTC_STICK like all the other devices from that
>     vendor? Looks inconsistent to me.

that's because it's the product name. Even though TERRATEC is the
vendor, the TERRATEC series of devices is different from the Cinergy
series (mostly due to software bundles, IMHO). See their homepage for
details.

So, TERRATEC_HTC_STICK would be wrong. You could change it to
TERRATEC_CINERGY_HTC_STICK, if it's important to you. However, following
the same logic, the TERRATEC H5 should then be called
TERRATEC_TERRATEC_H5, which seems rather odd.

Btw.: The em28xx driver wrongly lists the H5 as "Terratec Cinergy H5".

> 2. I stumbled over http://linux.terratec.de/tv_en.html where they list a NXP TDA18271
>     as used tuner for H5 and HTC Stick devices. I dont have any experience in this
>     kind of stuff but i am just asking.

That's right.

Regards,
Andreas

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Jens Erdmann]

Hi Andreas,

On Monday, November 28, 2011 05:57:35 PM you wrote:
> Hello Jens,
> 
> On 28.11.2011 16:41, Jens Erdmann wrote:
> > Hi folks,
> > 
> > just a few quetstions:
> > 1. Why is the device named EM2884_BOARD_CINERGY_HTC_STICK and not
> > 
> >     EM2884_BOARD_TERRATEC_HTC_STICK like all the other devices from that
> >     vendor? Looks inconsistent to me.
> 
> that's because it's the product name. Even though TERRATEC is the
> vendor, the TERRATEC series of devices is different from the Cinergy
> series (mostly due to software bundles, IMHO). See their homepage for
> details.
> 
> So, TERRATEC_HTC_STICK would be wrong. You could change it to
> TERRATEC_CINERGY_HTC_STICK, if it's important to you. However, following
> the same logic, the TERRATEC H5 should then be called
> TERRATEC_TERRATEC_H5, which seems rather odd.
> 
> Btw.: The em28xx driver wrongly lists the H5 as "Terratec Cinergy H5".
> 

Don't get me wrong on this. I am just asking. You have made the desicion
and if you are fine with it its ok.

> > 2. I stumbled over http://linux.terratec.de/tv_en.html where they list a
> > NXP TDA18271
> > 
> >     as used tuner for H5 and HTC Stick devices. I dont have any
> >     experience in this kind of stuff but i am just asking.
> 
> That's right.
> 

So this should be made like the other devices which are using the TDA18271?
Or is there no driver for this tuner yet?

Regards,

  Jens

PS: Thanks to Antti Palosaari for the detailed explanation.

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Andreas Oberritter]

On 29.11.2011 13:04, Jens Erdmann wrote:
> Hi Andreas,
> 
> On Monday, November 28, 2011 05:57:35 PM you wrote:
>> Hello Jens,
>>
>> On 28.11.2011 16:41, Jens Erdmann wrote:
>>> Hi folks,
>>>
>>> just a few quetstions:
>>> 1. Why is the device named EM2884_BOARD_CINERGY_HTC_STICK and not
>>>
>>>     EM2884_BOARD_TERRATEC_HTC_STICK like all the other devices from that
>>>     vendor? Looks inconsistent to me.
>>
>> that's because it's the product name. Even though TERRATEC is the
>> vendor, the TERRATEC series of devices is different from the Cinergy
>> series (mostly due to software bundles, IMHO). See their homepage for
>> details.
>>
>> So, TERRATEC_HTC_STICK would be wrong. You could change it to
>> TERRATEC_CINERGY_HTC_STICK, if it's important to you. However, following
>> the same logic, the TERRATEC H5 should then be called
>> TERRATEC_TERRATEC_H5, which seems rather odd.
>>
>> Btw.: The em28xx driver wrongly lists the H5 as "Terratec Cinergy H5".
>>
> 
> Don't get me wrong on this. I am just asking. You have made the desicion
> and if you are fine with it its ok.

No problem. I was just explaining the rationale. I don't really care
whether the constant's name gets changed or not.

>>> 2. I stumbled over http://linux.terratec.de/tv_en.html where they list a
>>> NXP TDA18271
>>>
>>>     as used tuner for H5 and HTC Stick devices. I dont have any
>>>     experience in this kind of stuff but i am just asking.
>>
>> That's right.
>>
> 
> So this should be made like the other devices which are using the TDA18271?
> Or is there no driver for this tuner yet?

I don't understand your question. Both TERRATEC H5 and Cinergy HTC Stick
are already supported by Linux (at least for digital signals, the latter
since the patch you're referring to), so a driver for every relevant
chip, including TDA18271, is already involved.

Regards,
Andreas

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Jens Erdmann]

Dear Andreas,

On Tuesday, November 29, 2011 01:56:35 PM you wrote:
<snip>
> 
> >>> 2. I stumbled over http://linux.terratec.de/tv_en.html where they list
> >>> a NXP TDA18271
> >>> 
> >>>     as used tuner for H5 and HTC Stick devices. I dont have any
> >>>     experience in this kind of stuff but i am just asking.
> >> 
> >> That's right.
> > 
> > So this should be made like the other devices which are using the
> > TDA18271? Or is there no driver for this tuner yet?
> 
> I don't understand your question. Both TERRATEC H5 and Cinergy HTC Stick
> are already supported by Linux (at least for digital signals, the latter
> since the patch you're referring to), so a driver for every relevant
> chip, including TDA18271, is already involved.
> 

If i remember correctly there was used another tuner driver in the out 
commended code. Is this just a coyp paste leftover?

Regards, 
  Jens

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Andreas Oberritter]

On 30.11.2011 20:39, Jens Erdmann wrote:
> Dear Andreas,
> 
> On Tuesday, November 29, 2011 01:56:35 PM you wrote:
> <snip>
>>
>>>>> 2. I stumbled over http://linux.terratec.de/tv_en.html where they list
>>>>> a NXP TDA18271
>>>>>
>>>>>     as used tuner for H5 and HTC Stick devices. I dont have any
>>>>>     experience in this kind of stuff but i am just asking.
>>>>
>>>> That's right.
>>>
>>> So this should be made like the other devices which are using the
>>> TDA18271? Or is there no driver for this tuner yet?
>>
>> I don't understand your question. Both TERRATEC H5 and Cinergy HTC Stick
>> are already supported by Linux (at least for digital signals, the latter
>> since the patch you're referring to), so a driver for every relevant
>> chip, including TDA18271, is already involved.
>>
> 
> If i remember correctly there was used another tuner driver in the out 
> commended code. Is this just a coyp paste leftover?

Hm. When Mauro committed the patch, the description got lost:

> - Can receive DVB-C and DVB-T. No analogue television or radio yet.
> - For now it's a copy of the Terratec H5 code with a different name.

So, to answer your question: The disabled code was copied from the H5
right above the new code, in the hope that if someone is going to fix
analogue TV for the H5, he or she might just fix it for the HTC Stick as
well, assuming that there's only little or no difference.

HTH,
Andreas

Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Mauro Carvalho Chehab]

On 30-11-2011 18:41, Andreas Oberritter wrote:
> On 30.11.2011 20:39, Jens Erdmann wrote:
>> Dear Andreas,
>>
>> On Tuesday, November 29, 2011 01:56:35 PM you wrote:
>> <snip>
>>>
>>>>>> 2. I stumbled over http://linux.terratec.de/tv_en.html where they list
>>>>>> a NXP TDA18271
>>>>>>
>>>>>>      as used tuner for H5 and HTC Stick devices. I dont have any
>>>>>>      experience in this kind of stuff but i am just asking.
>>>>>
>>>>> That's right.
>>>>
>>>> So this should be made like the other devices which are using the
>>>> TDA18271? Or is there no driver for this tuner yet?
>>>
>>> I don't understand your question. Both TERRATEC H5 and Cinergy HTC Stick
>>> are already supported by Linux (at least for digital signals, the latter
>>> since the patch you're referring to), so a driver for every relevant
>>> chip, including TDA18271, is already involved.
>>>
>>
>> If i remember correctly there was used another tuner driver in the out
>> commended code. Is this just a coyp paste leftover?
>
> Hm. When Mauro committed the patch, the description got lost:
>
>> - Can receive DVB-C and DVB-T. No analogue television or radio yet.
>> - For now it's a copy of the Terratec H5 code with a different name.

Gah! sorry for that. Not sure what happened there. I'll try to remember
about it when sending upstream, in order to recover the original comment.

Feel free to ping me closer to the next merge window, in order to remind
me.

>
> So, to answer your question: The disabled code was copied from the H5
> right above the new code, in the hope that if someone is going to fix
> analogue TV for the H5, he or she might just fix it for the HTC Stick as
> well, assuming that there's only little or no difference.

Support for analog is not trivial, as it requires writing a driver for
tvf4910b. Not sure if is there any publicly released driver with some
code for it. Maybe this could be done via sniffing the USB traffic, but, if
this device is as complicated as DRX, then I doubt people would try to
do it.

> HTH,
> Andreas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Andreas Oberritter]

- Can receive DVB-C and DVB-T. No analogue television or radio yet.
- For now it's a copy of the Terratec H5 code with a different name.

Signed-off-by: Andreas Oberritter <obi@linuxtv.org>
---
 linux/drivers/media/video/em28xx/em28xx-cards.c |   15 +++++++++++++++
 linux/drivers/media/video/em28xx/em28xx-dvb.c   |    1 +
 linux/drivers/media/video/em28xx/em28xx.h       |    1 +
 3 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/linux/drivers/media/video/em28xx/em28xx-cards.c b/linux/drivers/media/video/em28xx/em28xx-cards.c
index 9b747c2..03322d0 100644
--- a/linux/drivers/media/video/em28xx/em28xx-cards.c
+++ b/linux/drivers/media/video/em28xx/em28xx-cards.c
@@ -892,6 +892,19 @@ struct em28xx_board em28xx_boards[] = {
 				EM28XX_I2C_CLK_WAIT_ENABLE |
 				EM28XX_I2C_FREQ_400_KHZ,
 	},
+	[EM2884_BOARD_CINERGY_HTC_STICK] = {
+		.name         = "Terratec Cinergy HTC Stick",
+		.has_dvb      = 1,
+#if 0
+		.tuner_type   = TUNER_PHILIPS_TDA8290,
+		.tuner_addr   = 0x41,
+		.dvb_gpio     = terratec_h5_digital, /* FIXME: probably wrong */
+		.tuner_gpio   = terratec_h5_gpio,
+#endif
+		.i2c_speed    = EM2874_I2C_SECONDARY_BUS_SELECT |
+				EM28XX_I2C_CLK_WAIT_ENABLE |
+				EM28XX_I2C_FREQ_400_KHZ,
+	},
 	[EM2880_BOARD_HAUPPAUGE_WINTV_HVR_900] = {
 		.name         = "Hauppauge WinTV HVR 900",
 		.tda9887_conf = TDA9887_PRESENT,
@@ -1925,6 +1938,8 @@ struct usb_device_id em28xx_id_table[] = {
 			.driver_info = EM2860_BOARD_TERRATEC_GRABBY },
 	{ USB_DEVICE(0x0ccd, 0x10AF),
 			.driver_info = EM2860_BOARD_TERRATEC_GRABBY },
+	{ USB_DEVICE(0x0ccd, 0x00b2),
+			.driver_info = EM2884_BOARD_CINERGY_HTC_STICK },
 	{ USB_DEVICE(0x0fd9, 0x0033),
 			.driver_info = EM2860_BOARD_ELGATO_VIDEO_CAPTURE},
 	{ USB_DEVICE(0x185b, 0x2870),
diff --git a/linux/drivers/media/video/em28xx/em28xx-dvb.c b/linux/drivers/media/video/em28xx/em28xx-dvb.c
index cef7a2d..270cb98 100644
--- a/linux/drivers/media/video/em28xx/em28xx-dvb.c
+++ b/linux/drivers/media/video/em28xx/em28xx-dvb.c
@@ -789,6 +789,7 @@ static int em28xx_dvb_init(struct em28xx *dev)
 		}
 		break;
 	case EM2884_BOARD_TERRATEC_H5:
+	case EM2884_BOARD_CINERGY_HTC_STICK:
 		terratec_h5_init(dev);
 
 		dvb->dont_attach_fe1 = 1;
diff --git a/linux/drivers/media/video/em28xx/em28xx.h b/linux/drivers/media/video/em28xx/em28xx.h
index 2a2cb7e..5d763f7 100644
--- a/linux/drivers/media/video/em28xx/em28xx.h
+++ b/linux/drivers/media/video/em28xx/em28xx.h
@@ -121,6 +121,7 @@
 #define EM28174_BOARD_PCTV_290E                   78
 #define EM2884_BOARD_TERRATEC_H5		  79
 #define EM28174_BOARD_PCTV_460E                   80
+#define EM2884_BOARD_CINERGY_HTC_STICK		  81
 
 /* Limits minimum and default number of buffers */
 #define EM28XX_MIN_BUF 4