[PATCH resent] Fix logic in sanity check

[PATCH resent] Fix logic in sanity check

[Thomas Jarosch]

Detected by "cppcheck".

This time with "Signed-off-by" line.

Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>
---
 drivers/media/video/m5mols/m5mols_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/m5mols/m5mols_core.c b/drivers/media/video/m5mols/m5mols_core.c
index fb8e4a7..e485e9e 100644
--- a/drivers/media/video/m5mols/m5mols_core.c
+++ b/drivers/media/video/m5mols/m5mols_core.c
@@ -333,7 +333,7 @@ int m5mols_mode(struct m5mols_info *info, u8 mode)
 	int ret = -EINVAL;
 	u8 reg;
 
-	if (mode < REG_PARAMETER && mode > REG_CAPTURE)
+	if (mode < REG_PARAMETER || mode > REG_CAPTURE)
 		return ret;
 
 	ret = m5mols_read_u8(sd, SYSTEM_SYSMODE, &reg);
-- 
1.7.6.4

Re: [PATCH resent] Fix logic in sanity check

[Sylwester Nawrocki]

Hi Thomas,

On 10/15/2011 11:38 PM, Thomas Jarosch wrote:
> Detected by "cppcheck".
> 
> This time with "Signed-off-by" line.
> 
> Signed-off-by: Thomas Jarosch <thomas.jarosch@intra2net.com>

Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

> ---
>  drivers/media/video/m5mols/m5mols_core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/media/video/m5mols/m5mols_core.c b/drivers/media/video/m5mols/m5mols_core.c
> index fb8e4a7..e485e9e 100644
> --- a/drivers/media/video/m5mols/m5mols_core.c
> +++ b/drivers/media/video/m5mols/m5mols_core.c
> @@ -333,7 +333,7 @@ int m5mols_mode(struct m5mols_info *info, u8 mode)
>  	int ret = -EINVAL;
>  	u8 reg;
>  
> -	if (mode < REG_PARAMETER && mode > REG_CAPTURE)
> +	if (mode < REG_PARAMETER || mode > REG_CAPTURE)
>  		return ret;
>  
>  	ret = m5mols_read_u8(sd, SYSTEM_SYSMODE, &reg);

-- 
Regards,
Sylwester

Re: [PATCH resent] Fix logic in sanity check

[Sylwester Nawrocki]

Hi,

On 11/04/2011 10:16 AM, Sylwester Nawrocki wrote:
> On 10/15/2011 11:38 PM, Thomas Jarosch wrote:
>> Detected by "cppcheck".
>>
>> This time with "Signed-off-by" line.

When a note like this is added, not suitable for the changelog,
it should be placed after your SOB line, and below a line containing
only the "---" marker. Please check with Documentation/SubmittingPatches
for more details.

>>
>> Signed-off-by: Thomas Jarosch<thomas.jarosch@intra2net.com>
> 
> Acked-by: Sylwester Nawrocki<s.nawrocki@samsung.com>

Sorry, I was a bit too quick with this ack.


If you care to resend the patch, please add "m5mols:" as a subsystem name 
in the subject so it looks something like:

[PATCH ...] m5mols: Fix ... 

> 
>> ---
>>   drivers/media/video/m5mols/m5mols_core.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)

--
Thanks,
Sylwester

Re: [PATCH resent] Fix logic in sanity check

[Thomas Jarosch]

Hi Sylwester,

On Sunday, 20. November 2011 18:26:13 Sylwester Nawrocki wrote:
> If you care to resend the patch, please add "m5mols:" as a subsystem name
> in the subject so it looks something like:
> 
> [PATCH ...] m5mols: Fix ...
> 
> >> ---
> >> 
> >>   drivers/media/video/m5mols/m5mols_core.c |    2 +-
> >>   1 files changed, 1 insertions(+), 1 deletions(-)

I'll resend something soonish. Though feel free to
fix these cosmetic issues on the fly, too.

Cheers,
Thomas

Re: [PATCH resent] Fix logic in sanity check

[Sylwester Nawrocki]

Hi Thomas,

On 11/29/2011 01:26 PM, Thomas Jarosch wrote:
> On Sunday, 20. November 2011 18:26:13 Sylwester Nawrocki wrote:
>> If you care to resend the patch, please add "m5mols:" as a subsystem name
>> in the subject so it looks something like:
>>
>> [PATCH ...] m5mols: Fix ...
>>
>>>> ---
>>>>
>>>>   drivers/media/video/m5mols/m5mols_core.c |    2 +-
>>>>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> I'll resend something soonish. Though feel free to
> fix these cosmetic issues on the fly, too.

OK, sorry to bother. I'll pick the patch and amend it when adding
to a pull request.

-- 
Thanks!
Sylwester

> 
> Cheers,
> Thomas