Re: [PATCH] em28xx: Add Terratec Cinergy HTC Stick

[Andreas Oberritter <obi@linuxtv.org>]

On 30.11.2011 20:39, Jens Erdmann wrote:
> Dear Andreas,
> 
> On Tuesday, November 29, 2011 01:56:35 PM you wrote:
> <snip>
>>
>>>>> 2. I stumbled over http://linux.terratec.de/tv_en.html where they list
>>>>> a NXP TDA18271
>>>>>
>>>>>     as used tuner for H5 and HTC Stick devices. I dont have any
>>>>>     experience in this kind of stuff but i am just asking.
>>>>
>>>> That's right.
>>>
>>> So this should be made like the other devices which are using the
>>> TDA18271? Or is there no driver for this tuner yet?
>>
>> I don't understand your question. Both TERRATEC H5 and Cinergy HTC Stick
>> are already supported by Linux (at least for digital signals, the latter
>> since the patch you're referring to), so a driver for every relevant
>> chip, including TDA18271, is already involved.
>>
> 
> If i remember correctly there was used another tuner driver in the out 
> commended code. Is this just a coyp paste leftover?

Hm. When Mauro committed the patch, the description got lost:

> - Can receive DVB-C and DVB-T. No analogue television or radio yet.
> - For now it's a copy of the Terratec H5 code with a different name.

So, to answer your question: The disabled code was copied from the H5
right above the new code, in the hope that if someone is going to fix
analogue TV for the H5, he or she might just fix it for the HTC Stick as
well, assuming that there's only little or no difference.

HTH,
Andreas