Re: [PATCHv2] [media] drxk: Switch the delivery system on FE_SET_PROPERTY

Mauro Carvalho Chehab
2011-12-10T11:18:48Z

On 10-12-2011 02:00, Oliver Endriss wrote:
> On Friday 09 December 2011 20:00:12 Mauro Carvalho Chehab wrote:
>> The DRX-K doesn't change the delivery system at set_properties,
>> but do it at frontend init. This causes problems on programs like
>> w_scan that, by default, opens both frontends.
>>
>> Use adap->mfe_shared in order to prevent this, and be sure that Annex A
>> or C are properly selected.
>>
>> Signed-off-by: Mauro Carvalho Chehab<mchehab@redhat.com>
>> ---
>>
>> v2: Use mfe_shared
>>
>> drivers/media/dvb/frontends/drxk_hard.c | 16 ++++++++++------
>> drivers/media/dvb/frontends/drxk_hard.h | 2 ++
>> drivers/media/video/em28xx/em28xx-dvb.c | 4 ++++
>> 3 files changed, 16 insertions(+), 6 deletions(-)
> ...
>
> Please commit Manu's patch to 'Query DVB frontend delivery capabilities'.
> Then you will no longer have to struggle with multi-frontend problems.

I was waiting for him to submit the new version, as there were several
comments on the last series. Just checked that he submitted the new
version today. That will be a great improvement!

> We could finally get rid of having 2 mutual-exclusive frontends, which
> is just an ugly workaround, barely covered by the API spec...

Agreed.

Regards,
Mauro.