v4 [PATCH 00/10] Query DVB frontend delivery capabilities

v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Manu Abraham]

Hi,

 As discussed prior, the following changes help to advertise a
 frontend's delivery system capabilities.

 Sending out the patches as they are being worked out.

 The following patch series are applied against media_tree.git
 after the following commit

 commit e9eb0dadba932940f721f9d27544a7818b2fa1c5
 Author: Hans Verkuil <hans.verkuil@cisco.com>
 Date:   Tue Nov 8 11:02:34 2011 -0300

    [media] V4L menu: add submenu for platform devices

Re: v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Mauro Carvalho Chehab]

On 10-12-2011 02:41, Manu Abraham wrote:
> Hi,
>
>   As discussed prior, the following changes help to advertise a
>   frontend's delivery system capabilities.
>
>   Sending out the patches as they are being worked out.
>
>   The following patch series are applied against media_tree.git
>   after the following commit
>
>   commit e9eb0dadba932940f721f9d27544a7818b2fa1c5
>   Author: Hans Verkuil<hans.verkuil@cisco.com>
>   Date:   Tue Nov 8 11:02:34 2011 -0300
>
>      [media] V4L menu: add submenu for platform devices

 From my side, I'm happy with patches 1 to 5 and 9 to 10.

Patch 6 requires further discussion, patches 7 and 8 need changes
and the actual code there will depend on the discussions around patch 6.

As Antti has some issues with patch 9, I suggest that we should
merge patches 1 to 5 this weekend, if nobody objects, and keep discussing
the other two sets (6-8 and 9-10). After having this patch series applied,
a similar approach to the one taken by patches 9-10 will be needed by
the drivers using drx-k (ddbrige, ngene, em28xx), in order to change it
to be attached only once.

Regards,
Mauro

Re: v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Mauro Carvalho Chehab]

On 10-12-2011 02:41, Manu Abraham wrote:
> Hi,
>
>   As discussed prior, the following changes help to advertise a
>   frontend's delivery system capabilities.
>
>   Sending out the patches as they are being worked out.
>
>   The following patch series are applied against media_tree.git
>   after the following commit
>
>   commit e9eb0dadba932940f721f9d27544a7818b2fa1c5
>   Author: Hans Verkuil<hans.verkuil@cisco.com>
>   Date:   Tue Nov 8 11:02:34 2011 -0300
>
>      [media] V4L menu: add submenu for platform devices


A separate issue: please, don't send patches like that as attachment. It makes
hard for people review. Instead, you should use git send-email. There's even
an example there (at least on git version 1.7.8) showing how to set it for
Google:

$ git help send-email
...
EXAMPLE
    Use gmail as the smtp server
        To use git send-email to send your patches through the GMail SMTP server, edit ~/.gitconfig to specify your
        account settings:

            [sendemail]
                    smtpencryption = tls
                    smtpserver = smtp.gmail.com
                    smtpuser = yourname@gmail.com
                    smtpserverport = 587

        Once your commits are ready to be sent to the mailing list, run the following commands:

            $ git format-patch --cover-letter -M origin/master -o outgoing/
            $ edit outgoing/0000-*
            $ git send-email outgoing/*

        Note: the following perl modules are required Net::SMTP::SSL, MIME::Base64 and Authen::SASL
...

In practice, I generally just do this here:
	$ git send-email [some obj reference]

For example, when I want to send the last 3 patches, I just do:
	$ git send-email HEAD^1^1^1

Regards,
Mauro.

Re: v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Antti Palosaari]

On 12/10/2011 03:08 PM, Mauro Carvalho Chehab wrote:
> A separate issue: please, don't send patches like that as attachment. It
> makes
> hard for people review. Instead, you should use git send-email. There's
> even
> an example there (at least on git version 1.7.8) showing how to set it for
> Google:
>
> $ git help send-email
> ...
> EXAMPLE
> Use gmail as the smtp server
> To use git send-email to send your patches through the GMail SMTP
> server, edit ~/.gitconfig to specify your
> account settings:
>
> [sendemail]
> smtpencryption = tls
> smtpserver = smtp.gmail.com
> smtpuser = yourname@gmail.com
> smtpserverport = 587
>
> Once your commits are ready to be sent to the mailing list, run the
> following commands:
>
> $ git format-patch --cover-letter -M origin/master -o outgoing/
> $ edit outgoing/0000-*
> $ git send-email outgoing/*

I have SMTP which requires login over SSL. I am not sure if Git 
send-email event supports that but even if it supports I don't like idea 
to put my clear text password to some config file.

That's why I have used Thunderbird with External Editor and it sucks :/

Antti

-- 
http://palosaari.fi/

Re: v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Mauro Carvalho Chehab]

On 10-12-2011 11:15, Antti Palosaari wrote:
> On 12/10/2011 03:08 PM, Mauro Carvalho Chehab wrote:
>> A separate issue: please, don't send patches like that as attachment. It
>> makes
>> hard for people review. Instead, you should use git send-email. There's
>> even
>> an example there (at least on git version 1.7.8) showing how to set it for
>> Google:
>>
>> $ git help send-email
>> ...
>> EXAMPLE
>> Use gmail as the smtp server
>> To use git send-email to send your patches through the GMail SMTP
>> server, edit ~/.gitconfig to specify your
>> account settings:
>>
>> [sendemail]
>> smtpencryption = tls
>> smtpserver = smtp.gmail.com
>> smtpuser = yourname@gmail.com
>> smtpserverport = 587
>>
>> Once your commits are ready to be sent to the mailing list, run the
>> following commands:
>>
>> $ git format-patch --cover-letter -M origin/master -o outgoing/
>> $ edit outgoing/0000-*
>> $ git send-email outgoing/*
>
> I have SMTP which requires login over SSL. I am not sure if Git send-email event supports that but even if it supports I don't like idea to put my clear text password to some config file.

Git send-email supports it. The password can be given via command line. So,
you may even write a small script asking for a password to be used there, if
you don't want to have it on your shell history.

>
> That's why I have used Thunderbird with External Editor and it sucks :/
>
> Antti
>

Re: v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Mauro Carvalho Chehab]

On 10-12-2011 11:15, Antti Palosaari wrote:
> On 12/10/2011 03:08 PM, Mauro Carvalho Chehab wrote:
>> A separate issue: please, don't send patches like that as attachment. It
>> makes
>> hard for people review. Instead, you should use git send-email. There's
>> even
>> an example there (at least on git version 1.7.8) showing how to set it for
>> Google:
>>
>> $ git help send-email
>> ...
>> EXAMPLE
>> Use gmail as the smtp server
>> To use git send-email to send your patches through the GMail SMTP
>> server, edit ~/.gitconfig to specify your
>> account settings:
>>
>> [sendemail]
>> smtpencryption = tls
>> smtpserver = smtp.gmail.com
>> smtpuser = yourname@gmail.com
>> smtpserverport = 587
>>
>> Once your commits are ready to be sent to the mailing list, run the
>> following commands:
>>
>> $ git format-patch --cover-letter -M origin/master -o outgoing/
>> $ edit outgoing/0000-*
>> $ git send-email outgoing/*
>
> I have SMTP which requires login over SSL. I am not sure if Git send-email event supports that

It does.

> but even if it supports I don't like idea to put my clear text password to some config file.

You could then write a small script:

	#!/bin/bash
	echo -n Password:
	read
	git send-email --smtp-pass $REPLY

This would avoid storing your password at the bash history or at a config file.

> That's why I have used Thunderbird with External Editor and it sucks :/

git send-email will likely work a way better than that.

Regards,
Mauro

Re: v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Manu Abraham]

On Sat, Dec 10, 2011 at 6:38 PM, Mauro Carvalho Chehab
<mchehab@redhat.com> wrote:
> On 10-12-2011 02:41, Manu Abraham wrote:
>>
>> Hi,
>>
>>  As discussed prior, the following changes help to advertise a
>>  frontend's delivery system capabilities.
>>
>>  Sending out the patches as they are being worked out.
>>
>>  The following patch series are applied against media_tree.git
>>  after the following commit
>>
>>  commit e9eb0dadba932940f721f9d27544a7818b2fa1c5
>>  Author: Hans Verkuil<hans.verkuil@cisco.com>
>>  Date:   Tue Nov 8 11:02:34 2011 -0300
>>
>>     [media] V4L menu: add submenu for platform devices
>
>
>
> A separate issue: please, don't send patches like that as attachment. It
> makes
> hard for people review. Instead, you should use git send-email. There's even
> an example there (at least on git version 1.7.8) showing how to set it for
> Google:


I don't have net access configured for the box where I do
tests/on the testbox. The outgoing mail from my side is
through the gmail web interface. If I don't attach the
patches, gmail garbles those patches.

Re: v4 [PATCH 00/10] Query DVB frontend delivery capabilities

[Mauro Carvalho Chehab]

On 12-12-2011 04:35, Manu Abraham wrote:
> On Sat, Dec 10, 2011 at 6:38 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com>  wrote:
>> On 10-12-2011 02:41, Manu Abraham wrote:
>>>
>>> Hi,
>>>
>>>   As discussed prior, the following changes help to advertise a
>>>   frontend's delivery system capabilities.
>>>
>>>   Sending out the patches as they are being worked out.
>>>
>>>   The following patch series are applied against media_tree.git
>>>   after the following commit
>>>
>>>   commit e9eb0dadba932940f721f9d27544a7818b2fa1c5
>>>   Author: Hans Verkuil<hans.verkuil@cisco.com>
>>>   Date:   Tue Nov 8 11:02:34 2011 -0300
>>>
>>>      [media] V4L menu: add submenu for platform devices
>>
>>
>>
>> A separate issue: please, don't send patches like that as attachment. It
>> makes
>> hard for people review. Instead, you should use git send-email. There's even
>> an example there (at least on git version 1.7.8) showing how to set it for
>> Google:
>
>
> I don't have net access configured for the box where I do
> tests/on the testbox. The outgoing mail from my side is
> through the gmail web interface. If I don't attach the
> patches, gmail garbles those patches.

Not sure what you've meant by "net". Internet, or network, in general?

If you don't have an ethernet interface configured on your test box, you
can still put your git tree into a removable media (pen-driver or whatever)
and use it to transfer to your main machine, and then call git from it.

If you have Ethernet there, it is even simpler: from your main machine:

$ git pull remote:/patch/to/git my_branch

$ git send-email

Regards,
Mauro.