From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: [GIT PULL] af9013
Date: Sun, 11 Dec 2011 08:59:31 -0200 [thread overview]
Message-ID: <4EE48D13.7030702@redhat.com> (raw)
In-Reply-To: <4ED666E9.2020405@iki.fi>
On 30-11-2011 15:24, Antti Palosaari wrote:
> Morjens Mauro,
>
> I rewrote whole af9013 demodulator driver in order to decrease I2C load. Please pull that to the next Kernel merge window.
>
> Antti
>
> The following changes since commit a235af24a74a0fa03ece0a9f5e28a72e4d1e2cad:
>
> ce168: remove experimental from Kconfig (2011-11-19 23:07:54 +0200)
>
> are available in the git repository at:
> git://linuxtv.org/anttip/media_tree.git misc
>
> Antti Palosaari (1):
> af9013: rewrite whole driver
>
> drivers/media/dvb/dvb-usb/af9015.c | 82 +-
> drivers/media/dvb/frontends/af9013.c | 1756 ++++++++++++++---------------
> drivers/media/dvb/frontends/af9013.h | 113 +-
> drivers/media/dvb/frontends/af9013_priv.h | 93 +-
> 4 files changed, 1017 insertions(+), 1027 deletions(-)
>
There was a minor context change here:
@@ -1156,7 +1158,7 @@ static int af9015_af9013_sleep(struct dvb_frontend *fe)
if (mutex_lock_interruptible(&adap->dev->usb_mutex))
return -EAGAIN;
- ret = priv->init[adap->id](fe);
+ ret = priv->sleep[adap->id](fe);
Basically, the current code doesn't have that mutex_lock_interruptible logic. It
may be into the fixes we'll send for 3.2.
However, after this patch, compilation broke:
drivers/media/dvb/dvb-usb/af9015.c: In function ‘af9015_rc_query’:
drivers/media/dvb/dvb-usb/af9015.c:1089:12: error: ‘struct af9015_state’ has no member named ‘sleep’
drivers/media/dvb/dvb-usb/af9015.c:1089:20: error: ‘adap’ undeclared (first use in this function)
drivers/media/dvb/dvb-usb/af9015.c:1089:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/media/dvb/dvb-usb/af9015.c:1089:30: error: ‘fe’ undeclared (first use in this function)
Regards,
Mauro
next prev parent reply other threads:[~2011-12-11 10:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 17:24 [GIT PULL] af9013 Antti Palosaari
2011-12-11 10:59 ` Mauro Carvalho Chehab [this message]
2011-12-11 15:34 ` Antti Palosaari
2011-12-11 20:30 ` Mauro Carvalho Chehab
2011-12-11 21:03 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE48D13.7030702@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox