From: Antti Palosaari <crope@iki.fi>
To: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: linux-media@vger.kernel.org, Jyrki Kuoppala <jkp@iki.fi>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH] qt1010: Fix tuner frequency selection for 546 to 578 MHz range
Date: Wed, 21 Dec 2011 09:26:37 +0200 [thread overview]
Message-ID: <4EF18A2D.5090101@iki.fi> (raw)
In-Reply-To: <20111220105034.5150.54234.stgit@localhost>
Hello,
You can try to fix it like that, but it is not proper way. It is kinda
of hack which can just work or not. Proper way is to fix that tuner
driver correctly and if it was used with zl10353 demoed fix that driver
too to support IIRC IF/RF agc settings.
regards
Antti
On 12/20/2011 12:50 PM, Carlos Corbacho wrote:
> The patch fixes frequency selection for some UHF frequencies e.g.
> channel 32 (562 MHz) on the qt1010 tuner. For those in the UK,
> this now means they can tune to the BBC channels (tested on a Compro
> Vista T750F).
>
> One example of problem reports of the bug this fixes can be read at
> http://www.freak-search.com/de/thread/330303/linux-dvb_tuning_problem_with_some_frequencies_qt1010,_dvb
>
> Based on an original patch by Jyrki Kuoppala<jkp@iki.fi>
>
> Signed-off-by: Carlos Corbacho<carlos@strangeworlds.co.uk>
> Cc: Jyrki Kuoppala<jkp@iki.fi>
> Cc: Mauro Carvalho Chehab<mchehab@infradead.org>
> ---
> drivers/media/common/tuners/qt1010.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/common/tuners/qt1010.c b/drivers/media/common/tuners/qt1010.c
> index 9f5dba2..8c57d8c 100644
> --- a/drivers/media/common/tuners/qt1010.c
> +++ b/drivers/media/common/tuners/qt1010.c
> @@ -200,7 +200,8 @@ static int qt1010_set_params(struct dvb_frontend *fe,
> if (freq< 450000000) rd[15].val = 0xd0; /* 450 MHz */
> else if (freq< 482000000) rd[15].val = 0xd1; /* 482 MHz */
> else if (freq< 514000000) rd[15].val = 0xd4; /* 514 MHz */
> - else if (freq< 546000000) rd[15].val = 0xd7; /* 546 MHz */
> + else if (freq< 546000000) rd[15].val = 0xd6; /* 546 MHz */
> + else if (freq< 578000000) rd[15].val = 0xd8; /* 578 MHz */
> else if (freq< 610000000) rd[15].val = 0xda; /* 610 MHz */
> else rd[15].val = 0xd0;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-12-21 7:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 10:50 [PATCH] qt1010: Fix tuner frequency selection for 546 to 578 MHz range Carlos Corbacho
2011-12-21 7:26 ` Antti Palosaari [this message]
2011-12-21 7:42 ` Jyrki Kuoppala
2011-12-21 8:19 ` Antti Palosaari
[not found] ` <4EF1B69B.8020907@iki.fi>
2011-12-21 10:51 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EF18A2D.5090101@iki.fi \
--to=crope@iki.fi \
--cc=carlos@strangeworlds.co.uk \
--cc=jkp@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox