From: Hans de Goede <hdegoede@redhat.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>,
Theodore Kilgore <kilgota@banach.math.auburn.edu>
Subject: Re: [GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver
Date: Fri, 30 Dec 2011 12:39:02 +0100 [thread overview]
Message-ID: <4EFDA2D6.7000202@redhat.com> (raw)
In-Reply-To: <20111230122608.7f08efe7@tele>
Hi,
On 12/30/2011 12:26 PM, Jean-Francois Moine wrote:
> On Fri, 30 Dec 2011 11:56:38 +0100
> Hans de Goede<hdegoede@redhat.com> wrote:
>
>> I took it as is from Theodore, I guess we should do a separate cleanup
>> patch on top to preserve the history / authorship. Since I'm busy testing
>> the new isoc bandwidth stuff today, could you perhaps do a cleanup patch for this?
>
> Yes, but the first step is to remove this patch from the pull request, and only you may do it (it is only 3 git commands and an email - otherwise, it has no sense to add two empty lines in a patch and to remove them in an other one!).
Done.
I'll re-add it later, squashing the white-space fixes into the
patch and adding a patch on top to fix:
-err versus pr_err
-PDEBUG used with D_ERR everywhere where most cases should have
a different level
-the missing pixfmt documentation
Regards,
Hans
prev parent reply other threads:[~2011-12-30 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-30 9:29 [GIT PATCHES FOR 3.3] gspca patches and new jl2005bcd driver Hans de Goede
2011-12-30 10:24 ` Jean-Francois Moine
2011-12-30 10:56 ` Hans de Goede
2011-12-30 11:26 ` Jean-Francois Moine
2011-12-30 11:39 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EFDA2D6.7000202@redhat.com \
--to=hdegoede@redhat.com \
--cc=kilgota@banach.math.auburn.edu \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox