Re: ir-kbd-i2c / rc-hauppauge / linux-3.x broken

[Mauro Carvalho Chehab <mchehab@redhat.com>]

On 31-12-2011 08:15, Dorozel Csaba wrote:
>> Basically, the bridge driver is not sending the complete RC-5
>> keycode to the IR core, but just the 8 least siginificant bits.
>> So, it is loosing the 0x1e00 code for the Hauppauge grey remote.
>>
>> The fix should be at saa7134-input. It should be something like
>> the enclosed patch (I'm just guessing there that code3 contains
>> the MSB bits - you may need to adjust it to match the IR decoder
>> there):
> 
> I'm absolutly not a programer but an unhappy linux user who want his working remote back.
> Know nothing about c code, MSB bits ... After apply your fix looks what happening but remote is
> still broken.
> 
> user juuzer # ir-keytable -t
> Testing events. Please, press CTRL-C to abort.
> 1325324726.066129: event MSC: scancode = de3d
> 1325324726.066131: event sync
> 1325324726.169132: event MSC: scancode = de3d
> 1325324726.169134: event sync
> 1325324727.508129: event MSC: scancode = fe3d
> 1325324727.508131: event sync
> 1325324727.611132: event MSC: scancode = fe3d
> 1325324727.611134: event sync
> 1325324730.084132: event MSC: scancode = de3d
> 1325324730.084134: event sync
> 1325324730.187132: event MSC: scancode = de3d
> 
> It seems the code3 sometimes return with de (11011110) sometimes fe (11111110). Is it possible
> to bitwise left 3 then bitwise right 3 so the result in both case is 1e (00011110) ? Or its totaly
> wrong ?

An RC-5 code is just 14 bits. I found some Hauppauge decoders returning
just 12 bits on some places. It seems that all it needs is to do a
code3 | 0x3f, in order to discard the two most significant bits (MSB).

So, the enclosed patch should fix the issues. Please test.

Regards,
Mauro
-

saa7134-input: Fix get_key_hvr1110() handling

Instead of returning just 8 bits, return the full RC-5 code

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index d4ee24b..29c8efd 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -249,8 +249,8 @@ static int get_key_hvr1110(struct IR_i2c *ir, u32 *ir_key, u32 *ir_raw)
 		return 0;
 
 	/* return key */
-	*ir_key = code4;
-	*ir_raw = code4;
+	*ir_key = 0x3fff & (code4 | code3 << 8);
+	*ir_raw = *ir_key;
 	return 1;
 }


Regards,
Mauro
>