* [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt @ 2011-12-31 7:57 Hans de Goede 2011-12-31 7:58 ` [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt settings Hans de Goede 0 siblings, 1 reply; 3+ messages in thread From: Hans de Goede @ 2011-12-31 7:57 UTC (permalink / raw) To: Linux Media Mailing List; +Cc: Jean-Francois Moine Hi Mauro et all, I'm afraid my recent work on gscpa has uncovered another regression in the gspca core. It no longer properly falls back to a lower alt setting if there is not enough bandwidth for the initially choosen one. This is a problem when usb1 devices are plugged into a usb2 hub, or into a sandybridge motherboard (which uses usb2 hubs internally), since the ehci scheduling code in the kernel does not allow usb1 devices to use full iso bandwidth (long story). So we must fall back to a lower setting there! This means that many (iso mode) usb1 devices supported by gscpa won't work at their highest resolution with such systems. This patch fixes the falling back to lower alt settings, thereby also fixing these devices no longer working (reproduced and fix tested with several cams). Therefor I'm suggesting this fix as a last minute regression fix for 3.2 Mauro, please send this patch on its merry way to Linus, thanks! Regards, Hans ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt settings 2011-12-31 7:57 [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt Hans de Goede @ 2011-12-31 7:58 ` Hans de Goede 2011-12-31 13:32 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 3+ messages in thread From: Hans de Goede @ 2011-12-31 7:58 UTC (permalink / raw) To: Linux Media Mailing List; +Cc: Jean-Francois Moine, Hans de Goede The current gspca core code has a regression where it no longer properly falls back to lower alt settings when there is not enough bandwidth. This causes many iso based usb-1 cameras to not work when plugged into a usb2 hub or a sandybridge chipset motherboard! This patch fixes this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/media/video/gspca/gspca.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 7fb90ae..c27dc09 100644 --- a/drivers/media/video/gspca/gspca.c +++ b/drivers/media/video/gspca/gspca.c @@ -988,7 +988,7 @@ retry: ret = -EIO; goto out; } - alt = ep_tb[--alt_idx].alt; + gspca_dev->alt = ep_tb[--alt_idx].alt; } } out: -- 1.7.7.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt settings 2011-12-31 7:58 ` [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt settings Hans de Goede @ 2011-12-31 13:32 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 3+ messages in thread From: Mauro Carvalho Chehab @ 2011-12-31 13:32 UTC (permalink / raw) To: Linus Torvalds; +Cc: Linux Media Mailing List The current gspca core code has a regression where it no longer properly falls back to lower alt settings when there is not enough bandwidth. This causes many iso based usb-1 cameras to not work when plugged into a usb2 hub or a sandybridge chipset motherboard! This patch fixes this. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> --- drivers/media/video/gspca/gspca.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c index 7fb90ae..c27dc09 100644 --- a/drivers/media/video/gspca/gspca.c +++ b/drivers/media/video/gspca/gspca.c @@ -988,7 +988,7 @@ retry: ret = -EIO; goto out; } - alt = ep_tb[--alt_idx].alt; + gspca_dev->alt = ep_tb[--alt_idx].alt; } } out: -- 1.7.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-31 13:32 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-12-31 7:57 [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt Hans de Goede 2011-12-31 7:58 ` [PATCH for 3.2 URGENT] gspca: Fix falling back to lower isoc alt settings Hans de Goede 2011-12-31 13:32 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).