Re: [PATCHv2 00/94] Only use DVBv5 internally on frontend drivers

[Mauro Carvalho Chehab <mchehab@redhat.com>]

On 31-12-2011 13:31, Stefan Richter wrote:
> On Dec 30 Mauro Carvalho Chehab wrote:
>> Basically, changes all DVB frontend drivers to work directly with
>> the DVBv5 structure.
> [...]
>> Test reports are welcome.
> [...]
>>   [media] firedtv: convert set_fontend to use DVBv5 parameters
> [...]
>>  drivers/media/dvb/firewire/firedtv-avc.c     |   95 ++++++++--------
>>  drivers/media/dvb/firewire/firedtv-fe.c      |   31 ++----
>>  drivers/media/dvb/firewire/firedtv.h         |    4 +-
> 
> I briefly tested git://linuxtv.org/media_tree.gitstaging/for_v3.3
> 7c61d80a9bcf on top of v3.2-rc7 on a FireDTV-T/CI with kaffeine and on a
> FireDTV-C/CI with kaffeine and smplayer and didn't notice any runtime problem.

Thanks for testing it!

> Building fs/compat_ioctl.c failed for me though:
> fs/compat_ioctl.c:1345:1: error: invalid application of ‘sizeof’ to incomplete type ‘struct dvb_frontend_parameters’ 
> fs/compat_ioctl.c:1345:1: error: array type has incomplete element type
> etc. pp.

Yeah, I forgot about the compat stuff ;)

The fix is simple:
	http://git.linuxtv.org/media_tree.git/commit/e97a5d893fdf45c20799b72a1c11dca3b282c89c

Basically, one patch at the tree avoids the usage of DVBv3 
structs inside the drivers, as this is not supported by the
DVB core anymore. The core itself (and compat) will need it,
in order to provide DVBv3 compatibility.

Regards,
Mauro