[PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507

[PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507

[Vasily Khoruzhick]

Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
 lib/libv4lconvert/control/libv4lcontrol.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
index 12fa874..a9908ac 100644
--- a/lib/libv4lconvert/control/libv4lcontrol.c
+++ b/lib/libv4lconvert/control/libv4lcontrol.c
@@ -51,6 +51,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
 	/* Genius E-M 112 (also want whitebalance by default) */
 	{ 0x093a, 0x2476, 0, NULL, NULL,
 		V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
+	/* uvc-compatible cam from dealextreme (sku #44507) */
+	{ 0x18ec, 0x3366, 0, NULL, NULL, V4LCONTROL_HFLIPPED },
 
 	/* Laptops (and all in one PC's) */
 	{ 0x0402, 0x5606, 0,
-- 
1.7.8.1

Re: [PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507

[Hans de Goede]

Hi,


Thanks for the patch.

I'm sorry, but a quick google shows that your cam has a usb id used by various generic
cameras, including some microscopes, see:
http://blog.littleimpact.de/index.php/2011/10/16/using-biolux-nv-on-ubuntu-linux/

Enabling flipping on all these models because one has the sensor mounted upside down
is the wrong thing to do.

Instead you could add the following to your /etc/profile
export LIBV4LCONTROL_FLAGS=3

Note this will flip the image from all cameras you plug into your computer, or you
can keep a patched libv4l around for yourself.

Regards,

Hans


On 01/02/2012 09:25 PM, Vasily Khoruzhick wrote:
> Signed-off-by: Vasily Khoruzhick<anarsoul@gmail.com>
> ---
>   lib/libv4lconvert/control/libv4lcontrol.c |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c
> index 12fa874..a9908ac 100644
> --- a/lib/libv4lconvert/control/libv4lcontrol.c
> +++ b/lib/libv4lconvert/control/libv4lcontrol.c
> @@ -51,6 +51,8 @@ static const struct v4lcontrol_flags_info v4lcontrol_flags[] = {
>   	/* Genius E-M 112 (also want whitebalance by default) */
>   	{ 0x093a, 0x2476, 0, NULL, NULL,
>   		V4LCONTROL_HFLIPPED|V4LCONTROL_VFLIPPED | V4LCONTROL_WANTS_WB, 1500 },
> +	/* uvc-compatible cam from dealextreme (sku #44507) */
> +	{ 0x18ec, 0x3366, 0, NULL, NULL, V4LCONTROL_HFLIPPED },
>
>   	/* Laptops (and all in one PC's) */
>   	{ 0x0402, 0x5606, 0,

Re: [PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507

[Vasily]

2012/1/3 Hans de Goede <hdegoede@redhat.com>:
> Hi,
>
>
> Thanks for the patch.
>
> I'm sorry, but a quick google shows that your cam has a usb id used by
> various generic
> cameras, including some microscopes, see:
> http://blog.littleimpact.de/index.php/2011/10/16/using-biolux-nv-on-ubuntu-linux/
>
> Enabling flipping on all these models because one has the sensor mounted
> upside down
> is the wrong thing to do.
>
> Instead you could add the following to your /etc/profile
> export LIBV4LCONTROL_FLAGS=3
>
> Note this will flip the image from all cameras you plug into your computer,
> or you
> can keep a patched libv4l around for yourself.

Thanks, I'm OK with it :)

> Regards,
>
> Hans