* [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver [not found] <1325661469-4411-1-git-send-email-manjunath.hadli@ti.com> @ 2012-01-04 7:17 ` Manjunath Hadli 2012-01-04 12:59 ` Sergei Shtylyov 0 siblings, 1 reply; 3+ messages in thread From: Manjunath Hadli @ 2012-01-04 7:17 UTC (permalink / raw) To: dlos, LAK; +Cc: Manjunath Hadli, Mauro Carvalho Chehab, LMML remove unnecessary inclusion of machine specific header files mach/dm646x.h, mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c driver which comes in the way of platform code consolidation. Add linux/i2c.h header file in vpif_types.h which is required for building. Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com> Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: LMML <linux-media@vger.kernel.org> --- drivers/media/video/davinci/vpif.h | 2 -- drivers/media/video/davinci/vpif_display.c | 2 -- include/media/davinci/vpif_types.h | 2 ++ 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/davinci/vpif.h b/drivers/media/video/davinci/vpif.h index 25036cb..8bcac65 100644 --- a/drivers/media/video/davinci/vpif.h +++ b/drivers/media/video/davinci/vpif.h @@ -18,8 +18,6 @@ #include <linux/io.h> #include <linux/videodev2.h> -#include <mach/hardware.h> -#include <mach/dm646x.h> #include <media/davinci/vpif_types.h> /* Maximum channel allowed */ diff --git a/drivers/media/video/davinci/vpif_display.c b/drivers/media/video/davinci/vpif_display.c index 286f029..7fa34b4 100644 --- a/drivers/media/video/davinci/vpif_display.c +++ b/drivers/media/video/davinci/vpif_display.c @@ -39,8 +39,6 @@ #include <media/v4l2-ioctl.h> #include <media/v4l2-chip-ident.h> -#include <mach/dm646x.h> - #include "vpif_display.h" #include "vpif.h" diff --git a/include/media/davinci/vpif_types.h b/include/media/davinci/vpif_types.h index 9929b05..bd8217c 100644 --- a/include/media/davinci/vpif_types.h +++ b/include/media/davinci/vpif_types.h @@ -17,6 +17,8 @@ #ifndef _VPIF_TYPES_H #define _VPIF_TYPES_H +#include <linux/i2c.h> + #define VPIF_CAPTURE_MAX_CHANNELS 2 enum vpif_if_type { -- 1.6.2.4 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver 2012-01-04 7:17 ` [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver Manjunath Hadli @ 2012-01-04 12:59 ` Sergei Shtylyov 2012-01-04 14:27 ` Hadli, Manjunath 0 siblings, 1 reply; 3+ messages in thread From: Sergei Shtylyov @ 2012-01-04 12:59 UTC (permalink / raw) To: Manjunath Hadli; +Cc: dlos, LAK, LMML, Mauro Carvalho Chehab Hello. On 04-01-2012 11:17, Manjunath Hadli wrote: > remove unnecessary inclusion of machine specific header files mach/dm646x.h, > mach/hardware.h from vpif.h and aslo mach/dm646x.h from vpif_display.c > driver which comes in the way of platform code consolidation. > Add linux/i2c.h header file in vpif_types.h which is required for > building. This last modification should be in a separate patch. Don;t mix changes having the different purpose. > Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com> > Cc: Mauro Carvalho Chehab<mchehab@infradead.org> > Cc: LMML<linux-media@vger.kernel.org> WBR, Sergei ^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver 2012-01-04 12:59 ` Sergei Shtylyov @ 2012-01-04 14:27 ` Hadli, Manjunath 0 siblings, 0 replies; 3+ messages in thread From: Hadli, Manjunath @ 2012-01-04 14:27 UTC (permalink / raw) To: 'Sergei Shtylyov'; +Cc: dlos, LAK, LMML, Mauro Carvalho Chehab Sergei, On Wed, Jan 04, 2012 at 18:29:13, Sergei Shtylyov wrote: > Hello. > > On 04-01-2012 11:17, Manjunath Hadli wrote: > > > remove unnecessary inclusion of machine specific header files > > mach/dm646x.h, mach/hardware.h from vpif.h and aslo mach/dm646x.h > > from vpif_display.c driver which comes in the way of platform code consolidation. > > Add linux/i2c.h header file in vpif_types.h which is required for > > building. > > This last modification should be in a separate patch. Don;t mix changes having the different purpose. It is part of the same modification of removing the machine specific header. When the header file was removed, it needed the i2c to be included due to a dependency and hence the inclusion. Thx, -Manju > > > Signed-off-by: Manjunath Hadli<manjunath.hadli@ti.com> > > Cc: Mauro Carvalho Chehab<mchehab@infradead.org> > > Cc: LMML<linux-media@vger.kernel.org> > > WBR, Sergei > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-04 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1325661469-4411-1-git-send-email-manjunath.hadli@ti.com>
2012-01-04 7:17 ` [PATCH v8 1/2] davinci: vpif: remove machine specific header file inclusion from the driver Manjunath Hadli
2012-01-04 12:59 ` Sergei Shtylyov
2012-01-04 14:27 ` Hadli, Manjunath
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox