public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* Fix Leadtek DTV2000H radio tuner
@ 2011-12-17  0:39 Miroslav Slugeň
  2012-01-04 23:15 ` Mauro Carvalho Chehab
  2012-01-04 23:54 ` Miroslav Slugeň
  0 siblings, 2 replies; 5+ messages in thread
From: Miroslav Slugeň @ 2011-12-17  0:39 UTC (permalink / raw)
  To: linux-media

[-- Attachment #1: Type: text/plain, Size: 179 bytes --]

Leadtek DTV2000H J revision has FMD1216MEX, no older FMD1216ME. But
there is still another unknown issue with radio, because some stations
are just not working or are very noisy.

[-- Attachment #2: 0001-Leadtek-DTV2000H-J-has-Philips-FMD1216MEX-tuner-this.patch --]
[-- Type: text/x-patch, Size: 2823 bytes --]

From dadfa45664f765297e03e73a907ac04bd55e9b25 Mon Sep 17 00:00:00 2001
From: Miroslav <thunder.m@email.cz>
Date: Tue, 13 Dec 2011 19:36:15 +0100
Subject: [PATCH 1/2] Leadtek DTV2000H J has Philips FMD1216MEX tuner, this patch fixed not working
 radio part, but some stations are still not visible.

---
 drivers/media/video/cx88/cx88-cards.c |    3 ++-
 drivers/media/video/cx88/cx88-dvb.c   |   12 +++++++++++-
 drivers/media/video/tuner-core.c      |    1 +
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index dca369d..cbd5d11 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -1306,7 +1306,7 @@ static const struct cx88_board cx88_boards[] = {
 	},
 	[CX88_BOARD_WINFAST_DTV2000H_J] = {
 		.name           = "WinFast DTV2000 H rev. J",
-		.tuner_type     = TUNER_PHILIPS_FMD1216ME_MK3,
+		.tuner_type     = TUNER_PHILIPS_FMD1216MEX_MK3,
 		.radio_type     = UNSET,
 		.tuner_addr     = ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
@@ -3321,6 +3321,7 @@ static void cx88_card_setup_pre_i2c(struct cx88_core *core)
 		cx_set(MO_GP0_IO, 0x00001010);
 		break;
 
+	case CX88_BOARD_WINFAST_DTV2000H_J:
 	case CX88_BOARD_HAUPPAUGE_HVR3000:
 	case CX88_BOARD_HAUPPAUGE_HVR4000:
 		/* Init GPIO */
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index cf3d33a..592f3aa 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -999,7 +999,6 @@ static int dvb_register(struct cx8802_dev *dev)
 		}
 		break;
 	case CX88_BOARD_WINFAST_DTV2000H:
-	case CX88_BOARD_WINFAST_DTV2000H_J:
 	case CX88_BOARD_HAUPPAUGE_HVR1100:
 	case CX88_BOARD_HAUPPAUGE_HVR1100LP:
 	case CX88_BOARD_HAUPPAUGE_HVR1300:
@@ -1013,6 +1012,17 @@ static int dvb_register(struct cx8802_dev *dev)
 				goto frontend_detach;
 		}
 		break;
+	case CX88_BOARD_WINFAST_DTV2000H_J:
+		fe0->dvb.frontend = dvb_attach(cx22702_attach,
+					       &hauppauge_hvr_config,
+					       &core->i2c_adap);
+		if (fe0->dvb.frontend != NULL) {
+			if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
+				   &core->i2c_adap, 0x61,
+				   TUNER_PHILIPS_FMD1216MEX_MK3))
+				goto frontend_detach;
+		}
+		break;
 	case CX88_BOARD_HAUPPAUGE_HVR3000:
 		/* MFE frontend 1 */
 		mfe_shared = 1;
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index 8e7e769..bbfc04f 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -326,6 +326,7 @@ static void set_type(struct i2c_client *c, unsigned int type,
 		new_mode_mask = T_RADIO;
 		break;
 	case TUNER_PHILIPS_FMD1216ME_MK3:
+	case TUNER_PHILIPS_FMD1216MEX_MK3:
 		buffer[0] = 0x0b;
 		buffer[1] = 0xdc;
 		buffer[2] = 0x9c;
-- 
1.7.2.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Fix Leadtek DTV2000H radio tuner
  2011-12-17  0:39 Fix Leadtek DTV2000H radio tuner Miroslav Slugeň
@ 2012-01-04 23:15 ` Mauro Carvalho Chehab
  2012-01-04 23:54 ` Miroslav Slugeň
  1 sibling, 0 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2012-01-04 23:15 UTC (permalink / raw)
  To: Miroslav Slugeň; +Cc: linux-media

On 16-12-2011 22:39, Miroslav Slugeň wrote:
> Leadtek DTV2000H J revision has FMD1216MEX, no older FMD1216ME. But
> there is still another unknown issue with radio, because some stations
> are just not working or are very noisy.

Miroslav,

Please sign your patches with:
	Signed-off-by: your name <your@email>

As described at:

http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches

For the patches you've already send, you should reply to each of them with
your Signed-off-by. Patchwork will catch your signature.

Thanks!
Mauro

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Fix Leadtek DTV2000H radio tuner
  2011-12-17  0:39 Fix Leadtek DTV2000H radio tuner Miroslav Slugeň
  2012-01-04 23:15 ` Mauro Carvalho Chehab
@ 2012-01-04 23:54 ` Miroslav Slugeň
  2012-01-04 23:59   ` Mauro Carvalho Chehab
  1 sibling, 1 reply; 5+ messages in thread
From: Miroslav Slugeň @ 2012-01-04 23:54 UTC (permalink / raw)
  To: linux-media

[-- Attachment #1: Type: text/plain, Size: 28 bytes --]

Resending signed version...

[-- Attachment #2: 0001-Leadtek-DTV2000H-J-has-Philips-FMD1216MEX-tuner-this.patch --]
[-- Type: text/x-patch, Size: 2884 bytes --]

Signed-off-by: Miroslav Slugen <thunder.mmm@gmail.com>
From dadfa45664f765297e03e73a907ac04bd55e9b25 Mon Sep 17 00:00:00 2001
From: Miroslav Slugen <thunder.mmm@gmail.com>
Date: Tue, 13 Dec 2011 19:36:15 +0100
Subject: [PATCH] Leadtek DTV2000H J has Philips FMD1216MEX tuner, this patch fixed not working
 radio part, but some stations are still not visible.

---
 drivers/media/video/cx88/cx88-cards.c |    3 ++-
 drivers/media/video/cx88/cx88-dvb.c   |   12 +++++++++++-
 drivers/media/video/tuner-core.c      |    1 +
 3 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
index dca369d..cbd5d11 100644
--- a/drivers/media/video/cx88/cx88-cards.c
+++ b/drivers/media/video/cx88/cx88-cards.c
@@ -1306,7 +1306,7 @@ static const struct cx88_board cx88_boards[] = {
 	},
 	[CX88_BOARD_WINFAST_DTV2000H_J] = {
 		.name           = "WinFast DTV2000 H rev. J",
-		.tuner_type     = TUNER_PHILIPS_FMD1216ME_MK3,
+		.tuner_type     = TUNER_PHILIPS_FMD1216MEX_MK3,
 		.radio_type     = UNSET,
 		.tuner_addr     = ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
@@ -3321,6 +3321,7 @@ static void cx88_card_setup_pre_i2c(struct cx88_core *core)
 		cx_set(MO_GP0_IO, 0x00001010);
 		break;
 
+	case CX88_BOARD_WINFAST_DTV2000H_J:
 	case CX88_BOARD_HAUPPAUGE_HVR3000:
 	case CX88_BOARD_HAUPPAUGE_HVR4000:
 		/* Init GPIO */
diff --git a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
index cf3d33a..592f3aa 100644
--- a/drivers/media/video/cx88/cx88-dvb.c
+++ b/drivers/media/video/cx88/cx88-dvb.c
@@ -999,7 +999,6 @@ static int dvb_register(struct cx8802_dev *dev)
 		}
 		break;
 	case CX88_BOARD_WINFAST_DTV2000H:
-	case CX88_BOARD_WINFAST_DTV2000H_J:
 	case CX88_BOARD_HAUPPAUGE_HVR1100:
 	case CX88_BOARD_HAUPPAUGE_HVR1100LP:
 	case CX88_BOARD_HAUPPAUGE_HVR1300:
@@ -1013,6 +1012,17 @@ static int dvb_register(struct cx8802_dev *dev)
 				goto frontend_detach;
 		}
 		break;
+	case CX88_BOARD_WINFAST_DTV2000H_J:
+		fe0->dvb.frontend = dvb_attach(cx22702_attach,
+					       &hauppauge_hvr_config,
+					       &core->i2c_adap);
+		if (fe0->dvb.frontend != NULL) {
+			if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
+				   &core->i2c_adap, 0x61,
+				   TUNER_PHILIPS_FMD1216MEX_MK3))
+				goto frontend_detach;
+		}
+		break;
 	case CX88_BOARD_HAUPPAUGE_HVR3000:
 		/* MFE frontend 1 */
 		mfe_shared = 1;
diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
index 8e7e769..bbfc04f 100644
--- a/drivers/media/video/tuner-core.c
+++ b/drivers/media/video/tuner-core.c
@@ -326,6 +326,7 @@ static void set_type(struct i2c_client *c, unsigned int type,
 		new_mode_mask = T_RADIO;
 		break;
 	case TUNER_PHILIPS_FMD1216ME_MK3:
+	case TUNER_PHILIPS_FMD1216MEX_MK3:
 		buffer[0] = 0x0b;
 		buffer[1] = 0xdc;
 		buffer[2] = 0x9c;
-- 
1.7.2.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: Fix Leadtek DTV2000H radio tuner
  2012-01-04 23:54 ` Miroslav Slugeň
@ 2012-01-04 23:59   ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 5+ messages in thread
From: Mauro Carvalho Chehab @ 2012-01-04 23:59 UTC (permalink / raw)
  To: Miroslav Slugeň; +Cc: linux-media

On 04-01-2012 21:54, Miroslav Slugeň wrote:
> Resending signed version...

You need to do the same for the other patches you've sent ;)

Thanks
Mauro


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Fix Leadtek DTV2000H radio tuner
@ 2012-01-05 11:59 Miroslav Slugeň
  0 siblings, 0 replies; 5+ messages in thread
From: Miroslav Slugeň @ 2012-01-05 11:59 UTC (permalink / raw)
  To: linux-media

[-- Attachment #1: Type: text/plain, Size: 44 bytes --]

Resending signed-off version for kernel 3.2

[-- Attachment #2: Leadtek-DTV2000H-J-has-Philips-FMD1216MEX-tuner-this.patch --]
[-- Type: text/x-patch, Size: 2728 bytes --]

Signed-off-by: Miroslav Slugen <thunder.mmm@gmail.com>
From dadfa45664f765297e03e73a907ac04bd55e9b25 Mon Sep 17 00:00:00 2001
From: Miroslav Slugen <thunder.mmm@gmail.com>
Date: Tue, 13 Dec 2011 19:36:15 +0100
Subject: [PATCH] Leadtek DTV2000H J has Philips FMD1216MEX tuner, this patch fixed not working
 radio part, but some stations are still not visible.

---
diff -Naurp a/drivers/media/video/cx88/cx88-cards.c b/drivers/media/video/cx88/cx88-cards.c
--- a/drivers/media/video/cx88/cx88-cards.c	2012-01-05 00:55:44.000000000 +0100
+++ b/drivers/media/video/cx88/cx88-cards.c	2012-01-05 12:38:27.177910802 +0100
@@ -1306,7 +1306,7 @@ static const struct cx88_board cx88_boar
 	},
 	[CX88_BOARD_WINFAST_DTV2000H_J] = {
 		.name           = "WinFast DTV2000 H rev. J",
-		.tuner_type     = TUNER_PHILIPS_FMD1216ME_MK3,
+		.tuner_type     = TUNER_PHILIPS_FMD1216MEX_MK3,
 		.radio_type     = UNSET,
 		.tuner_addr     = ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
@@ -3232,6 +3232,7 @@ static void cx88_card_setup_pre_i2c(stru
 		cx_set(MO_GP0_IO, 0x00001010);
 		break;
 
+	case CX88_BOARD_WINFAST_DTV2000H_J:
 	case CX88_BOARD_HAUPPAUGE_HVR3000:
 	case CX88_BOARD_HAUPPAUGE_HVR4000:
 		/* Init GPIO */
diff -Naurp a/drivers/media/video/cx88/cx88-dvb.c b/drivers/media/video/cx88/cx88-dvb.c
--- a/drivers/media/video/cx88/cx88-dvb.c	2012-01-05 00:55:44.000000000 +0100
+++ b/drivers/media/video/cx88/cx88-dvb.c	2012-01-05 12:38:27.177910802 +0100
@@ -999,7 +999,6 @@ static int dvb_register(struct cx8802_de
 		}
 		break;
 	case CX88_BOARD_WINFAST_DTV2000H:
-	case CX88_BOARD_WINFAST_DTV2000H_J:
 	case CX88_BOARD_HAUPPAUGE_HVR1100:
 	case CX88_BOARD_HAUPPAUGE_HVR1100LP:
 	case CX88_BOARD_HAUPPAUGE_HVR1300:
@@ -1013,6 +1012,17 @@ static int dvb_register(struct cx8802_de
 				goto frontend_detach;
 		}
 		break;
+	case CX88_BOARD_WINFAST_DTV2000H_J:
+		fe0->dvb.frontend = dvb_attach(cx22702_attach,
+					       &hauppauge_hvr_config,
+					       &core->i2c_adap);
+		if (fe0->dvb.frontend != NULL) {
+			if (!dvb_attach(simple_tuner_attach, fe0->dvb.frontend,
+				   &core->i2c_adap, 0x61,
+				   TUNER_PHILIPS_FMD1216MEX_MK3))
+				goto frontend_detach;
+		}
+		break;
 	case CX88_BOARD_HAUPPAUGE_HVR3000:
 		/* MFE frontend 1 */
 		mfe_shared = 1;
diff -Naurp a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c
--- a/drivers/media/video/tuner-core.c	2012-01-05 00:55:44.000000000 +0100
+++ b/drivers/media/video/tuner-core.c	2012-01-05 12:38:27.177910802 +0100
@@ -326,6 +326,7 @@ static void set_type(struct i2c_client *
 		t->mode_mask = T_RADIO;
 		break;
 	case TUNER_PHILIPS_FMD1216ME_MK3:
+	case TUNER_PHILIPS_FMD1216MEX_MK3:
 		buffer[0] = 0x0b;
 		buffer[1] = 0xdc;
 		buffer[2] = 0x9c;

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-01-05 11:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-17  0:39 Fix Leadtek DTV2000H radio tuner Miroslav Slugeň
2012-01-04 23:15 ` Mauro Carvalho Chehab
2012-01-04 23:54 ` Miroslav Slugeň
2012-01-04 23:59   ` Mauro Carvalho Chehab
  -- strict thread matches above, loose matches on Subject: below --
2012-01-05 11:59 Miroslav Slugeň

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox