From: Sylwester Nawrocki <snjw23@gmail.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
"HeungJun, Kim" <riverful.kim@samsung.com>,
linux-media@vger.kernel.org, mchehab@redhat.com,
hverkuil@xs4all.nl, kyungmin.park@samsung.com,
Hans de Goede <hdegoede@redhat.com>,
Luca Risolia <luca.risolia@studio.unibo.it>
Subject: Re: [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control
Date: Fri, 13 Jan 2012 22:41:30 +0100 [thread overview]
Message-ID: <4F10A50A.4040009@gmail.com> (raw)
In-Reply-To: <20120111223616.GT9323@valkosipuli.localdomain>
On 01/11/2012 11:36 PM, Sakari Ailus wrote:
>>> This is what the spec says:
>>>
>>> "This is an action control. When set (the value is ignored), the device will do
>>> a white balance and then hold the current setting. Contrast this with the
>>> boolean V4L2_CID_AUTO_WHITE_BALANCE, which, when activated, keeps adjusting the
>>> white balance."
>>>
>>> I wonder if that should be then changed --- or is it just me who got a different
>>> idea from the above description?
>>
>> Only you ? :-) Same as Laurent, I understood this control can be used to do white
>> balance after pointing camera to a white object. Not sure if the description
>> needs to be changed.
>
> Definitely it needs to be changed. Who will submit the patch? :-)
If it really bugs you, feel free to send a patch :) Or I'll do it, but only after
I handle all other pending controls from my to-do list.
Cheers,
Sylwester
next prev parent reply other threads:[~2012-01-13 21:49 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-28 6:23 [RFC PATCH 0/4] Add some new camera controls HeungJun, Kim
2011-12-28 6:23 ` [RFC PATCH 1/4] v4l: Add V4L2_CID_PRESET_WHITE_BALANCE menu control HeungJun, Kim
2011-12-28 13:35 ` Sylwester Nawrocki
2011-12-28 13:51 ` Laurent Pinchart
2011-12-29 5:08 ` HeungJun, Kim
2011-12-29 23:58 ` Laurent Pinchart
2011-12-30 5:21 ` Kim, Heungjun
2011-12-30 10:30 ` Sylwester Nawrocki
2012-01-02 4:38 ` Kim, Heungjun
2012-01-02 21:50 ` Sylwester Nawrocki
2011-12-29 23:34 ` Sakari Ailus
2011-12-30 6:35 ` HeungJun, Kim
2011-12-30 8:41 ` Hans de Goede
2011-12-30 18:42 ` 'Sakari Ailus'
2011-12-30 18:56 ` Hans de Goede
2011-12-30 21:03 ` 'Sakari Ailus'
2011-12-30 18:17 ` 'Sakari Ailus'
2011-12-30 10:14 ` Sylwester Nawrocki
2011-12-30 20:41 ` Sakari Ailus
2012-01-01 15:38 ` Sylwester Nawrocki
2012-01-04 20:39 ` Sakari Ailus
2012-01-04 20:57 ` Laurent Pinchart
2012-01-04 21:24 ` Sakari Ailus
2012-01-04 22:06 ` Sylwester Nawrocki
2012-01-11 22:36 ` Sakari Ailus
2012-01-13 21:41 ` Sylwester Nawrocki [this message]
2011-12-29 4:06 ` HeungJun, Kim
2012-01-02 9:53 ` Sylwester Nawrocki
2011-12-30 11:23 ` Sylwester Nawrocki
2011-12-28 6:23 ` [RFC PATCH 2/4] v4l: Add V4L2_CID_SCENEMODE " HeungJun, Kim
2011-12-28 13:56 ` Laurent Pinchart
2011-12-29 5:40 ` HeungJun, Kim
2011-12-30 0:11 ` Laurent Pinchart
2011-12-30 5:31 ` HeungJun, Kim
2011-12-28 6:23 ` [RFC PATCH 3/4] v4l: Add V4L2_CID_WDR button control HeungJun, Kim
2011-12-28 13:56 ` Laurent Pinchart
2011-12-29 5:52 ` HeungJun, Kim
2011-12-30 0:13 ` Laurent Pinchart
2011-12-30 5:41 ` HeungJun, Kim
2011-12-30 21:10 ` Sakari Ailus
2011-12-28 6:23 ` [RFC PATCH 4/4] v4l: Add V4L2_CID_ANTISHAKE " HeungJun, Kim
2011-12-28 13:58 ` Laurent Pinchart
2011-12-29 5:57 ` HeungJun, Kim
2011-12-28 14:01 ` [RFC PATCH 0/4] Add some new camera controls Laurent Pinchart
2011-12-29 6:15 ` HeungJun, Kim
2011-12-30 0:16 ` Laurent Pinchart
2011-12-30 7:52 ` HeungJun, Kim
2011-12-30 11:18 ` Sylwester Nawrocki
2012-01-04 21:07 ` Sakari Ailus
2012-01-28 17:01 ` Sylwester Nawrocki
2012-01-30 22:25 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F10A50A.4040009@gmail.com \
--to=snjw23@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=luca.risolia@studio.unibo.it \
--cc=mchehab@redhat.com \
--cc=riverful.kim@samsung.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).