linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kruno Mrak <kruno.mrak@matrix-vision.de>
To: linux-media@vger.kernel.org
Subject: omap3isp: sequence number in v4l2 buffer not incremented
Date: Mon, 16 Jan 2012 11:32:19 +0100	[thread overview]
Message-ID: <4F13FCB3.10804@matrix-vision.de> (raw)

Hello,

we have an omap based intelligent camera and
image sensor is connected to camera parallel interface.
Image capturing via "CCDC output" works fine.
When streaming is on and reading "sequence" variable, it shows
always -1.
Looking at kernel-source ispvideo.c, i found following
if-else statement:

/* Do frame number propagation only if this is the output video node.
  * Frame number either comes from the CSI receivers or it gets
  * incremented here if H3A is not active.
  * Note: There is no guarantee that the output buffer will finish
  * first, so the input number might lag behind by 1 in some cases.
  */
if (video == pipe->output && !pipe->do_propagation)
	buf->vbuf.sequence = atomic_inc_return(&pipe->frame_number);
else
	buf->vbuf.sequence = atomic_read(&pipe->frame_number);

When i change to
if (video == pipe->output && pipe->do_propagation)
...
the sequence variable is incremented.

So my questions:
Could it be that "pipe->do_propagation" should be tested on true and
not on false?
If my changes are wrong, is there a reason why the sequence is not 
incremented?


Thanks,
Kruno Mrak



MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

             reply	other threads:[~2012-01-16 10:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16 10:32 Kruno Mrak [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-01-25 15:34 omap3isp: sequence number in v4l2 buffer not incremented Kruno Mrak
2012-02-09 16:08 ` Laurent Pinchart
2012-02-10 16:18   ` Kruno Mrak
2012-02-10 17:03     ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F13FCB3.10804@matrix-vision.de \
    --to=kruno.mrak@matrix-vision.de \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).