From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org, m.szyprowski@samsung.com,
kyungmin.park@samsung.com
Subject: Re: [PATCH 04/10] v4l: vb2: fixes for DMABUF support
Date: Mon, 23 Jan 2012 15:32:08 +0100 [thread overview]
Message-ID: <4F1D6F68.5040202@samsung.com> (raw)
In-Reply-To: <4F1D6D3E.7020203@redhat.com>
Hi Mauro,
On 01/23/2012 03:22 PM, Mauro Carvalho Chehab wrote:
> Em 23-01-2012 11:51, Tomasz Stanislawski escreveu:
>> Signed-off-by: Tomasz Stanislawski<t.stanislaws@samsung.com>
>> Signed-off-by: Kyungmin Park<kyungmin.park@samsung.com>
>
> Please better describe this patch. What is it supposing to fix?
Usually compilation error or bugs discovered in previous vb2-dma-contig
patches adding support for dma-buf.
>
>> ---
>> drivers/media/video/videobuf2-core.c | 21 +++++++++------------
>> include/media/videobuf2-core.h | 6 +++---
>> 2 files changed, 12 insertions(+), 15 deletions(-)
>>
>> diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c
>> index cb85874..59bb1bc 100644
>> --- a/drivers/media/video/videobuf2-core.c
>> +++ b/drivers/media/video/videobuf2-core.c
>> @@ -119,7 +119,7 @@ static void __vb2_buf_dmabuf_put(struct vb2_buffer *vb)
>> void *mem_priv = vb->planes[plane].mem_priv;
>>
>> if (mem_priv) {
>> - call_memop(q, plane, detach_dmabuf, mem_priv);
>> + call_memop(q, detach_dmabuf, mem_priv);
>
> Huh? You're not removing the "plane" parameter on this patch, but, instead,
> on a previous patch.
>
> No patch is allowed to break compilation, as it breaks git bisect.
I agree that patches should not break compilation if patches are
accepted to the mainline. There is a big compilation failure at patch 07
where videobuf2-dma-contig.c disappears.
Note that these are proof-of-concept patches for support of dma-buf
exporting/importing dma-buf in V4L2. It would be a waste of time
polished the patches if they are going to be rejected due to design flaws.
Regards,
Tomasz Stanislawski
next prev parent reply other threads:[~2012-01-23 14:32 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 13:51 [PATCH 00/10] Integration of videobuf2 with dmabuf Tomasz Stanislawski
2012-01-23 13:51 ` [PATCH 01/10] arm: dma: support for dma_get_pages Tomasz Stanislawski
2012-01-23 13:51 ` [PATCH 02/10] [media] media: vb2: remove plane argument from call_memop and cleanup mempriv usage Tomasz Stanislawski
2012-01-23 13:51 ` [PATCH 03/10] media: vb2: add prepare/finish callbacks to allocators Tomasz Stanislawski
2012-02-03 15:42 ` Pawel Osciak
2012-01-23 13:51 ` [PATCH 04/10] v4l: vb2: fixes for DMABUF support Tomasz Stanislawski
2012-01-23 14:22 ` Mauro Carvalho Chehab
2012-01-23 14:32 ` Tomasz Stanislawski [this message]
2012-01-23 14:52 ` Mauro Carvalho Chehab
2012-01-23 15:25 ` Tomasz Stanislawski
2012-01-23 16:06 ` Mauro Carvalho Chehab
2012-01-23 16:37 ` Tomasz Stanislawski
2012-01-23 16:51 ` Mauro Carvalho Chehab
2012-01-25 5:35 ` Semwal, Sumit
2012-01-25 10:34 ` Tomasz Stanislawski
2012-01-25 14:09 ` Semwal, Sumit
2012-01-23 13:51 ` [PATCH 05/10] v4l: add buffer exporting via dmabuf Tomasz Stanislawski
2012-01-23 14:32 ` Mauro Carvalho Chehab
2012-01-23 14:37 ` Laurent Pinchart
2012-01-23 14:42 ` Tomasz Stanislawski
2012-01-23 15:04 ` Mauro Carvalho Chehab
2012-01-23 15:56 ` Tomasz Stanislawski
2012-01-23 16:42 ` Mauro Carvalho Chehab
2012-01-23 16:57 ` V4L2 Overlay mode replacement by dma-buf - was: " Mauro Carvalho Chehab
2012-01-24 0:11 ` Clark, Rob
2012-01-24 9:44 ` Laurent Pinchart
2012-01-24 11:07 ` [Linaro-mm-sig] " Subash Patel
2012-01-24 12:06 ` Tomasz Stanislawski
2012-01-27 13:40 ` Subash Patel
2012-01-30 14:16 ` Laurent Pinchart
2012-01-26 9:48 ` Tomasz Stanislawski
2012-02-03 15:47 ` Pawel Osciak
2012-02-03 15:50 ` Pawel Osciak
2012-01-23 13:51 ` [PATCH 06/10] v4l: vb2: " Tomasz Stanislawski
2012-01-23 13:51 ` [PATCH 07/10] v4l: vb2: remove dma-contig allocator Tomasz Stanislawski
2012-01-23 14:24 ` Mauro Carvalho Chehab
2012-01-23 13:51 ` [PATCH 08/10] v4l: vb2-dma-contig: code refactoring, support for DMABUF exporting Tomasz Stanislawski
2012-01-23 14:26 ` Mauro Carvalho Chehab
2012-01-23 14:35 ` Tomasz Stanislawski
2012-01-23 14:43 ` Mauro Carvalho Chehab
2012-01-23 14:35 ` [PATCH] media: vb2-memops: Export vb2_get_vma symbol Laurent Pinchart
2012-01-23 14:44 ` Tomasz Stanislawski
2012-03-21 11:12 ` Laurent Pinchart
2012-01-23 13:51 ` [PATCH 09/10] v4l: fimc: integrate capture i-face with dmabuf Tomasz Stanislawski
2012-01-23 13:51 ` [PATCH 10/10] v4l: s5p-tv: mixer: integrate " Tomasz Stanislawski
2012-01-23 14:37 ` [PATCH 00/10] Integration of videobuf2 " Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1D6F68.5040202@samsung.com \
--to=t.stanislaws@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).