Re: [PATCH v4] [media] s5p-g2d: Add HFLIP and VFLIP support

[Sylwester Nawrocki <snjw23@gmail.com>]

Hi Sachin,

On 02/01/2012 10:48 AM, Sachin Kamat wrote:
> Add support for flipping the image horizontally and vertically.
> 
> Signed-off-by: Sachin Kamat<sachin.kamat@linaro.org>
> ---
>   drivers/media/video/s5p-g2d/g2d-hw.c |    5 +++++
>   drivers/media/video/s5p-g2d/g2d.c    |   27 ++++++++++++++++++++-------
>   drivers/media/video/s5p-g2d/g2d.h    |    4 ++++
>   3 files changed, 29 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/media/video/s5p-g2d/g2d-hw.c b/drivers/media/video/s5p-g2d/g2d-hw.c
> index 39937cf..5b86cbe 100644
> --- a/drivers/media/video/s5p-g2d/g2d-hw.c
> +++ b/drivers/media/video/s5p-g2d/g2d-hw.c
> @@ -77,6 +77,11 @@ void g2d_set_rop4(struct g2d_dev *d, u32 r)
>   	w(r, ROP4_REG);
>   }
> 
> +void g2d_set_flip(struct g2d_dev *d, u32 r)
> +{
> +	w(r, SRC_MSK_DIRECT_REG);
> +}

nit: This could be added instead to g2d.h as a "static inline" function.
Whether you decide to change it or not:

 Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

I assume Kamil is going to add locking in subsequent patch(es).

--

Regards,
Sylwester