From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.nokia.com ([147.243.1.48]:22204 "EHLO mgw-sa02.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754175Ab2BDUXm (ORCPT ); Sat, 4 Feb 2012 15:23:42 -0500 Message-ID: <4F2D93BA.7070703@iki.fi> Date: Sat, 04 Feb 2012 22:23:22 +0200 From: Sakari Ailus MIME-Version: 1.0 To: Sylwester Nawrocki CC: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com, dacohen@gmail.com, andriy.shevchenko@linux.intel.com, t.stanislaws@samsung.com, tuukkat76@gmail.com, k.debski@samsung.com, riverful@gmail.com, hverkuil@xs4all.nl, teturtia@gmail.com Subject: Re: [PATCH v2 09/31] v4l: Image source control class References: <20120202235231.GC841@valkosipuli.localdomain> <1328226891-8968-9-git-send-email-sakari.ailus@iki.fi> <4F2D7C28.6010909@gmail.com> In-Reply-To: <4F2D7C28.6010909@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sylwester, Thanks for the review! Sylwester Nawrocki wrote: > On 02/03/2012 12:54 AM, Sakari Ailus wrote: >> Add image source control class. This control class is intended to contain >> low level controls which deal with control of the image capture process --- >> the A/D converter in image sensors, for example. >> >> Signed-off-by: Sakari Ailus >> --- >> Documentation/DocBook/media/v4l/controls.xml | 86 ++++++++++++++++++++ >> .../DocBook/media/v4l/vidioc-g-ext-ctrls.xml | 6 ++ >> drivers/media/video/v4l2-ctrls.c | 7 ++ >> include/linux/videodev2.h | 9 ++ >> 4 files changed, 108 insertions(+), 0 deletions(-) >> >> diff --git a/Documentation/DocBook/media/v4l/controls.xml b/Documentation/DocBook/media/v4l/controls.xml >> index a1be378..6842e80 100644 >> --- a/Documentation/DocBook/media/v4l/controls.xml >> +++ b/Documentation/DocBook/media/v4l/controls.xml >> @@ -3379,4 +3379,90 @@ interface and may change in the future. >> >> >> >> + >> +
>> +Image Source Control Reference >> + >> + >> + Experimental >> + >> + This is an> + linkend="experimental">experimental interface and may >> + change in the future. >> + >> + >> + >> + The Image Source control class is intended for low-level >> + control of image source devices such as image sensors. The >> + devices feature an analogue to digital converter and a bus >> + transmitter to transmit the image data out of the device. >> + >> + >> + >> +Image Source Control IDs >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + >> + ID >> + Type >> + Description >> + >> + >> + >> + >> + >> + V4L2_CID_IMAGE_SOURCE_CLASS >> + class >> + >> + >> + The IMAGE_SOURCE class descriptor. >> + >> + >> + V4L2_CID_IMAGE_SOURCE_VBLANK >> + integer >> + >> + >> + Vertical blanking. The idle >> + preriod after every frame during which no image data is >> + produced. The unit of vertical blanking is a line. Every >> + line has length of the image width plus horizontal >> + blanking at the pixel clock specified by struct >> + v4l2_mbus_framefmt > The pixel clock is no longer specified by struct v4l2_mbus_framefmt, it's > now determined by V4L2_CID_IMAGE_PROC_LINK_FREQ controls, right ? I've had so many references to the pixel rate in the media bus frame format that it was inevitable some must have been left. :-o The V4L2_CID_IMAGE_PROC_PIXEL_RATE control will replace this. > When you drop the class name from the control names, it is perhaps better > to just use V4L2_CID_LINK_FREQUENCY name. I'll do that to the next patch.set. >> + />. >> + >> + >> + V4L2_CID_IMAGE_SOURCE_HBLANK >> + integer >> + >> + >> + Horizontal blanking. The idle >> + preriod after every line of image data during which no > > s/preriod/period Fixed. >> + image data is produced. The unit of horizontal blanking is >> + pixels. >> + >> + >> + V4L2_CID_IMAGE_SOURCE_ANALOGUE_GAIN >> + integer >> + >> + >> + Analogue gain is gain affecting >> + all colour components in the pixel matrix. The gain >> + operation is performed in the analogue domain before A/D >> + conversion. >> + >> + >> + >> + >> + >> +
>> + >> +
>> + >> >> diff --git a/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml b/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml >> index b17a7aa..f420034 100644 >> --- a/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml >> +++ b/Documentation/DocBook/media/v4l/vidioc-g-ext-ctrls.xml >> @@ -265,6 +265,12 @@ These controls are described in> These controls are described in> linkend="flash-controls" />. >> >> + >> + V4L2_CTRL_CLASS_IMAGE_SOURCE >> + 0x9d0000 The class containing image >> + source controls. These controls are described in> + linkend="image-source-controls" />. >> + >> >> >> >> diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c >> index 139ba42..37249b7 100644 >> --- a/drivers/media/video/v4l2-ctrls.c >> +++ b/drivers/media/video/v4l2-ctrls.c >> @@ -607,6 +607,12 @@ const char *v4l2_ctrl_get_name(u32 id) >> case V4L2_CID_FLASH_CHARGE: return "Charge"; >> case V4L2_CID_FLASH_READY: return "Ready to Strobe"; >> >> + /* Image source controls */ >> + case V4L2_CID_IMAGE_SOURCE_CLASS: return "Image source controls"; >> + case V4L2_CID_IMAGE_SOURCE_VBLANK: return "Vertical blanking"; >> + case V4L2_CID_IMAGE_SOURCE_HBLANK: return "Horizontal blanking"; >> + case V4L2_CID_IMAGE_SOURCE_ANALOGUE_GAIN: return "Analogue gain"; > > All words in control descriptions need to be capitalized. :-) Fixed. Kind regards, -- Sakari Ailus sakari.ailus@iki.fi