Re: [PATCH] smsdvb - fix UNDEFINED delivery on driver hotplug

Re: [PATCH] smsdvb - fix UNDEFINED delivery on driver hotplug

[Eddi De Pieri]

Someone can confirm my changes?

Regards,

Eddi

On Thu, Feb 2, 2012 at 10:13 AM, Eddi De Pieri <eddi@depieri.net> wrote:
> #dvb-fe-tool -a 1 -d DVBT
>
> Device Siano Mobile Digital MDTV Receiver (/dev/dvb/adapter1/frontend0)
> capabilities:
>
>         CAN_FEC_1_2 CAN_FEC_2_3 CAN_FEC_3_4 CAN_FEC_5_6 CAN_FEC_7_8
> CAN_FEC_AUTO CAN_GUARD_INTERVAL_AUTO CAN_HIERARCHY_AUTO CAN_INVERSION_AUTO
> CAN_QAM_16 CAN_QAM_64 CAN_QAM_AUTO CAN_QPSK CAN_RECOVER
> CAN_TRANSMISSION_MODE_AUTO
>
> DVB API Version 5.5, Current v5 delivery system: UNDEFINED
>
>
> Signed-off-by: Eddi De Pieri <eddi@depieri.net>
> ---
>  drivers/media/dvb/siano/smsdvb.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/dvb/siano/smsdvb.c
> b/drivers/media/dvb/siano/smsdvb.c
> index 654685c..7b584cb 100644
> --- a/drivers/media/dvb/siano/smsdvb.c
> +++ b/drivers/media/dvb/siano/smsdvb.c
> @@ -866,9 +866,6 @@ static int smsdvb_hotplug(struct smscore_device_t
> *coredev,
>         }
>
>         /* init and register frontend */
> -       memcpy(&client->frontend.ops, &smsdvb_fe_ops,
> -              sizeof(struct dvb_frontend_ops));
> -
>         switch (smscore_get_device_mode(coredev)) {
>         case DEVICE_MODE_DVBT:
>         case DEVICE_MODE_DVBT_BDA:
> @@ -880,6 +877,9 @@ static int smsdvb_hotplug(struct smscore_device_t
> *coredev,
>                 break;
>         }
>
> +       memcpy(&client->frontend.ops, &smsdvb_fe_ops,
> +              sizeof(struct dvb_frontend_ops));
> +
>         rc = dvb_register_frontend(&client->adapter, &client->frontend);
>         if (rc < 0) {
>                 sms_err("frontend registration failed %d", rc);
> --
> 1.7.2.5
>
>

Re: [PATCH] smsdvb - fix UNDEFINED delivery on driver hotplug

[Gianluca Gennari]

Il 14/02/2012 23:35, Eddi De Pieri ha scritto:
> Someone can confirm my changes?
> 
> Regards,
> 
> Eddi

Hi Eddi,
your patch makes sense to me, but I think you will have to resubmit it
to the list, as the original mail has never been published (I can only
see your reply to it). Also, your patch is not listed on patchwork, so
it must have been lost.

Regards,
Gianluca

Re: [PATCH] smsdvb - fix UNDEFINED delivery on driver hotplug

[Mauro Carvalho Chehab]

Em 20-02-2012 09:59, Gianluca Gennari escreveu:
> Il 14/02/2012 23:35, Eddi De Pieri ha scritto:
>> Someone can confirm my changes?
>>
>> Regards,
>>
>> Eddi
> 
> Hi Eddi,
> your patch makes sense to me, but I think you will have to resubmit it
> to the list, as the original mail has never been published (I can only
> see your reply to it). Also, your patch is not listed on patchwork, so
> it must have been lost.

Yes, you should re-submit it. Please be sure that your emailer won't mangle
it, as otherwise patchwork won't catch it.

Regards,
Mauro
> 
> Regards,
> Gianluca
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] smsdvb - fix UNDEFINED delivery on driver hotplug

[Mauro Carvalho Chehab]

Em 01-03-2012 07:06, Mauro Carvalho Chehab escreveu:
> Em 20-02-2012 09:59, Gianluca Gennari escreveu:
>> Il 14/02/2012 23:35, Eddi De Pieri ha scritto:
>>> Someone can confirm my changes?
>>>
>>> Regards,
>>>
>>> Eddi
>>
>> Hi Eddi,
>> your patch makes sense to me, but I think you will have to resubmit it
>> to the list, as the original mail has never been published (I can only
>> see your reply to it). Also, your patch is not listed on patchwork, so
>> it must have been lost.
> 
> Yes, you should re-submit it. Please be sure that your emailer won't mangle
> it, as otherwise patchwork won't catch it.

After looking on your patch, I think that the best fix is the patch below.
Instead of changing the fe_ops template, we should modify the per-client
copy.

Regards,
Mauro

-

smsusb: fix the default delivery system setting

There are two issues on the default delivery system setting for smsusb:

	1) instead of filling the delivery system for the per-client
	   frontend.ops, it were changing the global structure;

	2) The client->frontend.ops copy were keeping the previous value
	   of the template. So, the first time the device was inserted,
	   it was using the wrong value.

Reported-by: Eddi De Pieri <eddi@depieri.net>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/dvb/siano/smsdvb.c b/drivers/media/dvb/siano/smsdvb.c
index 654685c..e2dc80d 100644
--- a/drivers/media/dvb/siano/smsdvb.c
+++ b/drivers/media/dvb/siano/smsdvb.c
@@ -872,11 +872,11 @@ static int smsdvb_hotplug(struct smscore_device_t *coredev,
 	switch (smscore_get_device_mode(coredev)) {
 	case DEVICE_MODE_DVBT:
 	case DEVICE_MODE_DVBT_BDA:
-		smsdvb_fe_ops.delsys[0] = SYS_DVBT;
+		client->frontend.ops.delsys[0] = SYS_DVBT;
 		break;
 	case DEVICE_MODE_ISDBT:
 	case DEVICE_MODE_ISDBT_BDA:
-		smsdvb_fe_ops.delsys[0] = SYS_ISDBT;
+		client->frontend.ops.delsys[0] = SYS_ISDBT;
 		break;
 	}