* possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git
@ 2012-02-05 11:53 Eddi De Pieri
2012-03-01 10:12 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 3+ messages in thread
From: Eddi De Pieri @ 2012-02-05 11:53 UTC (permalink / raw)
To: linux-media, mchehab
Hi mauro,
I suspect a bug in follow code:
for (bw = 0; fe_bandwidth_name[bw] != 0; bw++) {
if (fe_bandwidth_name[bw] == v3_parms.u.ofdm.bandwidth)
break;
}
dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
I think should be something like:
int bw_idx;
dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
for (bw_idx = 0; fe_bandwidth_name[bw_idx] != 0; bw_idx++) {
if (fe_bandwidth_name[bw_idx] == bw) {
v3_parms.u.ofdm.bandwidth = bw;
break;
}
}
regards,
Eddi De Pieri
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git
2012-02-05 11:53 possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git Eddi De Pieri
@ 2012-03-01 10:12 ` Mauro Carvalho Chehab
[not found] ` <CAKdnbx6P=MhCV+aoUxeFEdWCseeJSfAd2UgjhZJHjRNA7NtGog@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2012-03-01 10:12 UTC (permalink / raw)
To: Eddi De Pieri; +Cc: linux-media
Hi Eddi,
Em 05-02-2012 09:53, Eddi De Pieri escreveu:
> Hi mauro,
>
> I suspect a bug in follow code:
>
> for (bw = 0; fe_bandwidth_name[bw] != 0; bw++) {
> if (fe_bandwidth_name[bw] == v3_parms.u.ofdm.bandwidth)
> break;
> }
> dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
>
> I think should be something like:
>
> int bw_idx;
>
> dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
>
> for (bw_idx = 0; fe_bandwidth_name[bw_idx] != 0; bw_idx++) {
> if (fe_bandwidth_name[bw_idx] == bw) {
> v3_parms.u.ofdm.bandwidth = bw;
> break;
> }
> }
>
> regards,
I've aplied the dvb code at the main v4l-utils tree some time ago. Since then,
I'm applying the fixes directly there. So, please check if the issue you're pointing
weren't fix yet there. If not, please send me a patch.
Thanks!
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git
[not found] ` <CAKdnbx6P=MhCV+aoUxeFEdWCseeJSfAd2UgjhZJHjRNA7NtGog@mail.gmail.com>
@ 2012-03-01 20:39 ` Eddi De Pieri
0 siblings, 0 replies; 3+ messages in thread
From: Eddi De Pieri @ 2012-03-01 20:39 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media
Hi Mauro,
> I've aplied the dvb code at the main v4l-utils tree some time ago. Since then,
> I'm applying the fixes directly there. So, please check if the issue you're pointing
> weren't fix yet there. If not, please send me a patch.
The code is still unchanged.
I prefere you double check my suggested patch below since I don't
fully understand your code.
However sound strange to me that you compute "bw" value and then you
overwrite it.
> I suspect a bug in follow code:
>
> for (bw = 0; fe_bandwidth_name[bw] != 0; bw++) {
> if (fe_bandwidth_name[bw] == v3_parms.u.ofdm.bandwidth)
> break;
> }
> dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
>
> I think should be something like:
>
> int bw_idx;
>
> dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
>
> for (bw_idx = 0; fe_bandwidth_name[bw_idx] != 0; bw_idx++) {
> if (fe_bandwidth_name[bw_idx] == bw) {
> v3_parms.u.ofdm.bandwidth = bw;
> break;
> }
> }
Regards,
Eddi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-01 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-05 11:53 possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git Eddi De Pieri
2012-03-01 10:12 ` Mauro Carvalho Chehab
[not found] ` <CAKdnbx6P=MhCV+aoUxeFEdWCseeJSfAd2UgjhZJHjRNA7NtGog@mail.gmail.com>
2012-03-01 20:39 ` Eddi De Pieri
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox