possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git

possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git

[Eddi De Pieri]

Hi mauro,

I suspect a bug in follow code:

                for (bw = 0; fe_bandwidth_name[bw] != 0; bw++) {
                        if (fe_bandwidth_name[bw] == v3_parms.u.ofdm.bandwidth)
                                break;
                }
                dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);

I think should be something like:

                int bw_idx;

                dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);

                for (bw_idx = 0; fe_bandwidth_name[bw_idx] != 0; bw_idx++) {
                        if (fe_bandwidth_name[bw_idx] == bw) {
                                v3_parms.u.ofdm.bandwidth = bw;
                                break;
                        }
                }

regards,


Eddi De Pieri

Re: possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git

[Mauro Carvalho Chehab]

Hi Eddi,

Em 05-02-2012 09:53, Eddi De Pieri escreveu:
> Hi mauro,
> 
> I suspect a bug in follow code:
> 
>                 for (bw = 0; fe_bandwidth_name[bw] != 0; bw++) {
>                         if (fe_bandwidth_name[bw] == v3_parms.u.ofdm.bandwidth)
>                                 break;
>                 }
>                 dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
> 
> I think should be something like:
> 
>                 int bw_idx;
> 
>                 dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
> 
>                 for (bw_idx = 0; fe_bandwidth_name[bw_idx] != 0; bw_idx++) {
>                         if (fe_bandwidth_name[bw_idx] == bw) {
>                                 v3_parms.u.ofdm.bandwidth = bw;
>                                 break;
>                         }
>                 }
> 
> regards,

I've aplied the dvb code at the main v4l-utils tree some time ago. Since then,
I'm applying the fixes directly there. So, please check if the issue you're pointing
weren't fix yet there. If not, please send me a patch.

Thanks!
Mauro

Re: possible bug in http://git.linuxtv.org/mchehab/experimental-v4l-utils.git

[Eddi De Pieri]

Hi Mauro,

> I've aplied the dvb code at the main v4l-utils tree some time ago. Since then,
> I'm applying the fixes directly there. So, please check if the issue you're pointing
> weren't fix yet there. If not, please send me a patch.

The code is still unchanged.

I prefere you double check my suggested patch below since I don't
fully understand your code.

However sound strange to me that you compute "bw" value and then you
overwrite it.


> I suspect a bug in follow code:
>
>                 for (bw = 0; fe_bandwidth_name[bw] != 0; bw++) {
>                         if (fe_bandwidth_name[bw] == v3_parms.u.ofdm.bandwidth)
>                                 break;
>                 }
>                 dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
>
> I think should be something like:
>
>                 int bw_idx;
>
>                 dvb_fe_retrieve_parm(parms, DTV_BANDWIDTH_HZ, &bw);
>
>                 for (bw_idx = 0; fe_bandwidth_name[bw_idx] != 0; bw_idx++) {
>                         if (fe_bandwidth_name[bw_idx] == bw) {
>                                 v3_parms.u.ofdm.bandwidth = bw;
>                                 break;
>                         }
>                 }

Regards,
Eddi