* [PATCH] [media] s5p-tv: Fix section mismatch warning in mixer_video.c
@ 2012-03-12 6:13 Sachin Kamat
2012-03-12 11:05 ` Tomasz Stanislawski
0 siblings, 1 reply; 2+ messages in thread
From: Sachin Kamat @ 2012-03-12 6:13 UTC (permalink / raw)
To: linux-media; +Cc: t.stanislaws, kyungmin.park, mchehab, sachin.kamat, patches
The function __devinit mxr_probe() references
a function __devexit mxr_release_video().
Since mxr_release_video() is referenced outside the exit section, the following
compilation warning is generated which is fixed here:
WARNING: drivers/media/video/s5p-tv/s5p-mixer.o(.devinit.text+0x340):
Section mismatch in reference from the function mxr_probe() to the function
.devexit.text:mxr_release_video()
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
Tested on for-next branch of Kukjin Kim's tree
git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git
---
drivers/media/video/s5p-tv/mixer.h | 2 +-
drivers/media/video/s5p-tv/mixer_video.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/s5p-tv/mixer.h b/drivers/media/video/s5p-tv/mixer.h
index 1597078..b02e55c 100644
--- a/drivers/media/video/s5p-tv/mixer.h
+++ b/drivers/media/video/s5p-tv/mixer.h
@@ -293,7 +293,7 @@ int __devinit mxr_acquire_video(struct mxr_device *mdev,
struct mxr_output_conf *output_cont, int output_count);
/** releasing common video resources */
-void __devexit mxr_release_video(struct mxr_device *mdev);
+void mxr_release_video(struct mxr_device *mdev);
struct mxr_layer *mxr_graph_layer_create(struct mxr_device *mdev, int idx);
struct mxr_layer *mxr_vp_layer_create(struct mxr_device *mdev, int idx);
diff --git a/drivers/media/video/s5p-tv/mixer_video.c b/drivers/media/video/s5p-tv/mixer_video.c
index 7884bae..aa5996c 100644
--- a/drivers/media/video/s5p-tv/mixer_video.c
+++ b/drivers/media/video/s5p-tv/mixer_video.c
@@ -141,7 +141,7 @@ fail:
return ret;
}
-void __devexit mxr_release_video(struct mxr_device *mdev)
+void mxr_release_video(struct mxr_device *mdev)
{
int i;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] s5p-tv: Fix section mismatch warning in mixer_video.c
2012-03-12 6:13 [PATCH] [media] s5p-tv: Fix section mismatch warning in mixer_video.c Sachin Kamat
@ 2012-03-12 11:05 ` Tomasz Stanislawski
0 siblings, 0 replies; 2+ messages in thread
From: Tomasz Stanislawski @ 2012-03-12 11:05 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-media, kyungmin.park, mchehab, patches
Hi Sachin Kamat,
Thank you for finding and fixing this bug.
I will add your patch to the next pull-request for s5p-tv updates.
Regards,
Tomasz Stanislawski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-12 11:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-12 6:13 [PATCH] [media] s5p-tv: Fix section mismatch warning in mixer_video.c Sachin Kamat
2012-03-12 11:05 ` Tomasz Stanislawski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).