public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Furniss <andyqos@ukfsn.org>
To: Gianluca Gennari <gennarone@gmail.com>
Cc: linux-media@vger.kernel.org, mchehab@redhat.com,
	dheitmueller@kernellabs.com
Subject: Re: [PATCH] em28xx: pre-allocate DVB isoc transfer buffers
Date: Fri, 16 Mar 2012 00:25:42 +0000	[thread overview]
Message-ID: <4F628886.3050009@ukfsn.org> (raw)
In-Reply-To: <1329155962-22896-1-git-send-email-gennarone@gmail.com>

Gianluca Gennari wrote:
> (was: Re: PCTV 290e page allocation failure)
>
> On MIPS/ARM set-top-boxes, as well as old x86 PCs, memory allocation failures
> in the em28xx driver are common, due to memory fragmentation over time, that
> makes impossible to allocate large chunks of coherent memory.
> A typical system with 256/512 MB of RAM fails after just 1 day of uptime (see
> the old thread for detailed reports and crashlogs).
>
> In fact, the em28xx driver allocates memory for USB isoc transfers at runtime,
> as opposite to the dvb-usb drivers that allocates the USB buffers when the
> device is initialized, and frees them when the device is disconnected.
>
> Moreover, in digital mode the USB isoc transfer buffers are freed, allocated
> and cleared every time the user selects a new channel, wasting time and
> resources.

Does this patch have a chance of getting in?

I am still having to flush caches before use. If you want more testing I 
can give it a go. I didn't earlier as I didn't have a git to apply it to 
and thought it was going to get in anyway.


  parent reply	other threads:[~2012-03-16  0:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 17:59 [PATCH] em28xx: pre-allocate DVB isoc transfer buffers Gianluca Gennari
2012-02-19 23:46 ` Chris Rankin
2012-02-20  0:18   ` Gianluca Gennari
2012-03-16  0:25 ` Andy Furniss [this message]
2012-03-16  1:38   ` Gianluca Gennari
2012-03-16  1:38   ` Gianluca Gennari
2012-03-16 10:16     ` Andy Furniss
2012-03-16 15:05       ` Andy Furniss
2012-03-16 15:39         ` Gianluca Gennari
2012-03-16 15:51           ` Andy Furniss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F628886.3050009@ukfsn.org \
    --to=andyqos@ukfsn.org \
    --cc=dheitmueller@kernellabs.com \
    --cc=gennarone@gmail.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox