From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: linuxtv@stefanringel.de
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 01/22] mt2063: trivial change
Date: Mon, 19 Mar 2012 21:02:23 -0300 [thread overview]
Message-ID: <4F67C90F.3030000@redhat.com> (raw)
In-Reply-To: <1329256066-8844-1-git-send-email-linuxtv@stefanringel.de>
Em 14-02-2012 19:47, linuxtv@stefanringel.de escreveu:
> From: Stefan Ringel <linuxtv@stefanringel.de>
>
> Signed-off-by: Stefan Ringel <linuxtv@stefanringel.de>
> ---
> drivers/media/common/tuners/mt2063.c | 23 +++++++++++++++--------
> 1 files changed, 15 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/common/tuners/mt2063.c b/drivers/media/common/tuners/mt2063.c
> index 0ed9091..872e9c0 100644
> --- a/drivers/media/common/tuners/mt2063.c
> +++ b/drivers/media/common/tuners/mt2063.c
> @@ -1,12 +1,13 @@
> /*
> - * Driver for mt2063 Micronas tuner
> + * Driver for microtune mt2063 tuner
> *
> * Copyright (c) 2011 Mauro Carvalho Chehab <mchehab@redhat.com>
> + * Copyright (c) 2012 Stefan Ringel <linuxtv@stefanringel.de>
> *
> * This driver came from a driver originally written by:
> - * Henry Wang <Henry.wang@AzureWave.com>
> + * Henry Wang <Henry.wang@AzureWave.com>
> * Made publicly available by Terratec, at:
> - * http://linux.terratec.de/files/TERRATEC_H7/20110323_TERRATEC_H7_Linux.tar.gz
> + * http://linux.terratec.de/files/TERRATEC_H7/20110323_TERRATEC_H7_Linux.tar.gz
> * The original driver's license is GPL, as declared with MODULE_LICENSE()
> *
> * This program is free software; you can redistribute it and/or modify
> @@ -29,13 +30,14 @@
>
> static unsigned int debug;
> module_param(debug, int, 0644);
> -MODULE_PARM_DESC(debug, "Set Verbosity level");
> +MODULE_PARM_DESC(debug, "Set debug level");
>
> -#define dprintk(level, fmt, arg...) do { \
> -if (debug >= level) \
> - printk(KERN_DEBUG "mt2063 %s: " fmt, __func__, ## arg); \
> -} while (0)
>
> +/* debug level
> + * 0 don't debug
> + * 1 called functions without i2c comunications
> + * 2 additional calculating, result etc.
> + * 3 maximum debug information
A */ is missing here.
>
> /* positive error codes used internally */
>
> @@ -60,6 +62,10 @@ if (debug >= level) \
> * check against this version number to make sure that
> * it matches the version that the tuner driver knows about.
> */
> +#define dprintk(level, fmt, arg...) do { \
> +if (debug >= level) \
> + printk(KERN_DEBUG "mt2063 %s: " fmt, __func__, ##arg); \
> +} while (0)
>
> /* DECT Frequency Avoidance */
> #define MT2063_DECT_AVOID_US_FREQS 0x00000001
> @@ -2305,3 +2311,4 @@ EXPORT_SYMBOL_GPL(tuner_MT2063_ClearPowerMaskBits);
> MODULE_AUTHOR("Mauro Carvalho Chehab <mchehab@redhat.com>");
> MODULE_DESCRIPTION("MT2063 Silicon tuner");
> MODULE_LICENSE("GPL");
> +MODULE_VERSION("0.2");
prev parent reply other threads:[~2012-03-20 0:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 21:47 [PATCH 01/22] mt2063: trivial change linuxtv
2012-02-14 21:47 ` [PATCH 02/22] mt2063: remove unused functions linuxtv
2012-02-14 21:47 ` [PATCH 03/22] mt2063: add hybrid linuxtv
2012-03-20 0:03 ` Mauro Carvalho Chehab
2012-02-14 21:47 ` [PATCH 04/22] mt2063: remove dect linuxtv
2012-03-20 0:08 ` Mauro Carvalho Chehab
2012-02-14 21:47 ` [PATCH 05/22] mt2063: remove spurcheck linuxtv
2012-03-20 0:09 ` Mauro Carvalho Chehab
2012-02-14 21:47 ` [PATCH 06/22] mt2063: remove remove up + down converter linuxtv
2012-02-14 21:47 ` [PATCH 07/22] mt2063: read_reg, write_reg linuxtv
2012-02-14 21:47 ` [PATCH 08/22] mt2063: add shutdown linuxtv
2012-02-14 21:47 ` [PATCH 09/22] mt2063: move global setting into a header file linuxtv
2012-02-14 21:47 ` [PATCH 10/22] mt2063: new set_mode linuxtv
2012-02-14 21:47 ` [PATCH 11/22] mt2063: remove get_bandwidth linuxtv
2012-02-14 21:47 ` [PATCH 12/22] mt2063: remove LockStatus linuxtv
2012-02-14 21:47 ` [PATCH 13/22] mt2063: new tune function linuxtv
2012-02-14 21:47 ` [PATCH 14/22] mt2063: remove get_status linuxtv
2012-02-14 21:47 ` [PATCH 15/22] mt_2063: add mt2063_sleep linuxtv
2012-02-14 21:47 ` [PATCH 16/22] mt2063: add hybrid stuff in release function linuxtv
2012-02-14 21:47 ` [PATCH 17/22] mt2063: chane set_analog_params linuxtv
2012-02-14 21:47 ` [PATCH 18/22] mt2063: add get_if_frequency linuxtv
2012-02-14 21:47 ` [PATCH 19/22] mt2063: remove old get_if_frequency linuxtv
2012-02-14 21:47 ` [PATCH 20/22] mt2063: change set_params function linuxtv
2012-02-14 21:47 ` [PATCH 21/22] mt2063: change mt2063_init linuxtv
2012-02-14 21:47 ` [PATCH 22/22] mt2063: add mt2063_find_chip linuxtv
2012-03-20 0:02 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F67C90F.3030000@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=linuxtv@stefanringel.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).