linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Jones <michael.jones@matrix-vision.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media ML <linux-media@vger.kernel.org>
Subject: Re: reading config parameters of omap3-isp subdevs
Date: Tue, 20 Mar 2012 11:06:56 +0100	[thread overview]
Message-ID: <4F6856C0.4070404@matrix-vision.de> (raw)
In-Reply-To: <6085689.3CUf0tMs8E@avalon>

Hi Laurent,

On 03/20/2012 12:22 AM, Laurent Pinchart wrote:
> Hi Michael,
>
> On Friday 16 March 2012 15:06:15 Michael Jones wrote:
[snip]
>
> Adding a R/W bit to the flag argument should indeed work. However, I'm
> wondering what your use case for reading parameters back is.

The simplest use case in my mind is that after the user has fiddled 
around with config parameters, they should be able to set them back to 
their original state.  For that, they need to know what the original 
state was.

 > The preview
> engine parameter structures seem pretty-much self-contained to me, I'm not
> sure it would make sense to only modify one of the parameters.

Why doesn't it make sense to write to only e.g. 'COEF3' in the 
PRV_WBGAIN register?  Especially considering the sparse documentation of 
many of these registers, I would like to be able to tweak the existing 
parameters from their defaults, rather than start from scratch.

-Michael

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner, Erhard Meier

  reply	other threads:[~2012-03-20 10:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 14:06 reading config parameters of omap3-isp subdevs Michael Jones
2012-03-19 23:22 ` Laurent Pinchart
2012-03-20 10:06   ` Michael Jones [this message]
2012-03-28 15:54     ` Laurent Pinchart
  -- strict thread matches above, loose matches on Subject: below --
2012-03-25 23:42 Joshua Hintze

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6856C0.4070404@matrix-vision.de \
    --to=michael.jones@matrix-vision.de \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).