Add usb device id for tm6000-cards.c

Add usb device id for tm6000-cards.c

[Marek Chmielewski]

[-- Attachment #1: Type: text/plain, Size: 33 bytes --]

-- 
Pozdrawiam
Marek Chmielewski

[-- Attachment #2: patch_for_tm6000-cards.patch --]
[-- Type: text/x-patch, Size: 639 bytes --]

--- tm6000-cards.c.bakup	2012-03-10 14:34:07.471348336 +0100
+++ tm6000-cards.c	2012-03-10 15:18:09.856380721 +0100
@@ -615,6 +615,7 @@
 struct usb_device_id tm6000_id_table[] = {
 	{ USB_DEVICE(0x6000, 0x0001), .driver_info = TM5600_BOARD_GENERIC },
 	{ USB_DEVICE(0x6000, 0x0002), .driver_info = TM6010_BOARD_GENERIC },
+	{ USB_DEVICE(0x0572, 0x262a), .driver_info = TM5600_BOARD_GENERIC },
 	{ USB_DEVICE(0x06e1, 0xf332), .driver_info = TM6000_BOARD_ADSTECH_DUAL_TV },
 	{ USB_DEVICE(0x14aa, 0x0620), .driver_info = TM6000_BOARD_FREECOM_AND_SIMILAR },
 	{ USB_DEVICE(0x06e1, 0xb339), .driver_info = TM6000_BOARD_ADSTECH_MINI_DUAL_TV },

Re: Add usb device id for tm6000-cards.c

[Sylwester Nawrocki]

Hello,

On 03/22/2012 08:37 PM, Marek Chmielewski wrote:

You need to at least add your "Signed-off-by" in order to have the patch 
applied to the mainline kernel. Also, it would be good to send the patch
inlined, rather than as an attachment. 

I suggest using git format-patch, git send-email.

More details can be found here:
http://linuxtv.org/wiki/index.php/Development:_How_to_submit_patches

Thanks,
Sylwester

Re: Add usb device id for tm6000-cards.c

[Mauro Carvalho Chehab]

Em 22-03-2012 16:37, Marek Chmielewski escreveu:
> -- Pozdrawiam Marek Chmielewski
> 
> 
> patch_for_tm6000-cards.patch
> 
> 
> --- tm6000-cards.c.bakup	2012-03-10 14:34:07.471348336 +0100
> +++ tm6000-cards.c	2012-03-10 15:18:09.856380721 +0100

Please, use it ad diff -p1 format (e. g. a/drivers/media/video/tm6000/tm6000-cards.c). 
A tool like quilt or git would do it for you.

> @@ -615,6 +615,7 @@
>  struct usb_device_id tm6000_id_table[] = {
>  	{ USB_DEVICE(0x6000, 0x0001), .driver_info = TM5600_BOARD_GENERIC },
>  	{ USB_DEVICE(0x6000, 0x0002), .driver_info = TM6010_BOARD_GENERIC },
> +	{ USB_DEVICE(0x0572, 0x262a), .driver_info = TM5600_BOARD_GENERIC },

Hmm... different USB vendor??? Are you sure this is a generic board? It seems unlikely that
Trident would be using a different Vendor ID there.

If this is not a "Generic" ID (e.g. a Trident SDK ID), then you should, instead, create an
entry for your board.

>  	{ USB_DEVICE(0x06e1, 0xf332), .driver_info = TM6000_BOARD_ADSTECH_DUAL_TV },
>  	{ USB_DEVICE(0x14aa, 0x0620), .driver_info = TM6000_BOARD_FREECOM_AND_SIMILAR },
>  	{ USB_DEVICE(0x06e1, 0xb339), .driver_info = TM6000_BOARD_ADSTECH_MINI_DUAL_TV },
> 

Regards,
Mauro