From: Antti Palosaari <crope@iki.fi>
To: "Michael Büsch" <m@bues.ch>
Cc: linux-media@vger.kernel.org, "Daniel Glöckner" <daniel-gl@gmx.net>
Subject: Re: [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 => TerraTec Cinergy T Stick [0ccd:0093]
Date: Sun, 01 Apr 2012 16:19:46 +0300 [thread overview]
Message-ID: <4F7855F2.4010201@iki.fi> (raw)
In-Reply-To: <20120401151153.637d2393@milhouse>
On 01.04.2012 16:11, Michael Büsch wrote:
> On Sun, 01 Apr 2012 15:29:07 +0300
> Antti Palosaari<crope@iki.fi> wrote:
>> buf[1] = msg[0].addr<< 1;
>> Maybe you have given I2C address as a "8bit" format?
>
> Uhh, the address is leftshifted by one.
> So I changed the i2c address from 0xC0 to 0x60.
That's a very common mistake, I2C addresses are 7 bit and LSB is
direction. But it is very common to see used it as a "8bit" format, 0xC0
write address and 0xc1 as a read address. Even some data-sheets have
that "wrong" naming.
There is many drivers that is wrong and causing confusion, even my old
AF9015... :]
> The i2c write seems to work now. At least it doesn't complain anymore
> and it sorta seems to tune to the right frequency.
> But i2c read may be broken.
> I had to enable the commented read code, but it still fails to read
> the VCO calibration value:
>
> [ 3101.940765] i2c i2c-8: Failed to read VCO calibration value (got 20)
>
> It doesn't run into this check on the other af903x driver.
> So I suspect an i2c read issue here.
That could be I2C adapter issue too, TUA9001 does not use it and thus
not tested at all... But for my eyes it looks logically correct still.
> Attached: The patches.
Lets see.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-04-01 13:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-30 12:33 [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 => TerraTec Cinergy T Stick [0ccd:0093] Antti Palosaari
2012-03-30 21:45 ` Michael Büsch
2012-03-30 22:00 ` Antti Palosaari
2012-03-30 22:14 ` Michael Büsch
2012-03-31 14:04 ` Michael Büsch
2012-03-31 14:28 ` Antti Palosaari
2012-03-31 16:29 ` Michael Büsch
2012-03-31 16:34 ` Antti Palosaari
2012-03-31 16:48 ` Antti Palosaari
2012-03-31 16:52 ` Michael Büsch
2012-04-01 4:51 ` Antti Palosaari
2012-04-01 8:33 ` Michael Büsch
2012-04-01 12:19 ` Michael Büsch
2012-04-01 12:29 ` Antti Palosaari
2012-04-01 13:11 ` Michael Büsch
2012-04-01 13:19 ` Antti Palosaari [this message]
2012-04-01 14:42 ` Hans-Frieder Vogt
2012-04-01 14:56 ` Michael Büsch
2012-04-01 16:24 ` Hans-Frieder Vogt
2012-04-01 16:36 ` Michael Büsch
2012-04-01 16:15 ` Michael Büsch
2012-04-01 16:20 ` Antti Palosaari
2012-04-01 16:32 ` Michael Büsch
2012-04-01 16:39 ` Antti Palosaari
2012-04-01 16:44 ` Michael Büsch
2012-04-01 9:56 ` Gianluca Gennari
2012-04-01 10:27 ` Hans-Frieder Vogt
2012-04-01 12:31 ` Antti Palosaari
2012-04-01 14:31 ` Hans-Frieder Vogt
2012-04-01 15:00 ` Antti Palosaari
2012-04-01 15:04 ` Hans-Frieder Vogt
2012-04-01 12:53 ` Antti Palosaari
2012-04-01 17:15 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 support for AverTV A867R (mxl5007t tuner) Hans-Frieder Vogt
2012-04-01 17:24 ` Antti Palosaari
2012-04-01 18:11 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 i2c read fix Hans-Frieder Vogt
2012-04-01 18:16 ` Antti Palosaari
2012-04-01 21:07 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 support for AverTV A867R (mxl5007t), version 2 Hans-Frieder Vogt
2012-04-01 21:19 ` [PATCH] AF9033 read_ber and read_ucblocks implementation Hans-Frieder Vogt
2012-04-01 21:56 ` Antti Palosaari
2012-04-01 22:11 ` Antti Palosaari
2012-04-01 21:32 ` [PATCH][GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 support for AverTV A867R (mxl5007t), version 2 Antti Palosaari
2012-04-02 17:02 ` Hans-Frieder Vogt
2012-03-31 16:49 ` [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 => TerraTec Cinergy T Stick [0ccd:0093] Michael Büsch
2012-04-06 11:11 ` Antti Palosaari
2012-05-07 18:44 ` [GIT PULL FOR 3.5] AF9035/AF9033 Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7855F2.4010201@iki.fi \
--to=crope@iki.fi \
--cc=daniel-gl@gmx.net \
--cc=linux-media@vger.kernel.org \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).