From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:38997 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547Ab2DAQUX (ORCPT ); Sun, 1 Apr 2012 12:20:23 -0400 Message-ID: <4F788045.40208@iki.fi> Date: Sun, 01 Apr 2012 19:20:21 +0300 From: Antti Palosaari MIME-Version: 1.0 To: =?UTF-8?B?TWljaGFlbCBCw7xzY2g=?= CC: linux-media@vger.kernel.org, =?UTF-8?B?RGFuaWVsIEdsw7Zja25lcg==?= Subject: Re: [GIT PULL FOR 3.5] AF9035/AF9033/TUA9001 => TerraTec Cinergy T Stick [0ccd:0093] References: <4F75A7FE.8090405@iki.fi> <20120330234545.45f4e2e8@milhouse> <4F762CF5.9010303@iki.fi> <20120331001458.33f12d82@milhouse> <20120331160445.71cd1e78@milhouse> <4F771496.8080305@iki.fi> <20120331182925.3b85d2bc@milhouse> <4F77320F.8050009@iki.fi> <4F773562.6010008@iki.fi> <20120331185217.2c82c4ad@milhouse> <4F77DED5.2040103@iki.fi> <20120401103315.1149d6bf@milhouse> <20120401141940.04e5220c@milhouse> <4F784A13.5000704@iki.fi> <20120401151153.637d2393@milhouse> <20120401181502.7f5604c3@milhouse> In-Reply-To: <20120401181502.7f5604c3@milhouse> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On 01.04.2012 19:15, Michael Büsch wrote: > On Sun, 1 Apr 2012 15:11:53 +0200 > Michael Büsch wrote: > >> [ 3101.940765] i2c i2c-8: Failed to read VCO calibration value (got 20) > > Ok, it turns out that it doesn't fail all the time, but only sporadically. > So increasing the number of retries fixes (or at least works around) it. OK, feel free to add ~3 retries inside af9035_ctrl_msg() i think. You didn't mention if error is coming from af9035 firmware or from USB stack. Just for the interest... > No idea why this behaves differently from fc0011 on Hans' driver, though. Maybe some delay or there is retry on error logic. regards Antti -- http://palosaari.fi/