linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antti Palosaari <crope@iki.fi>
To: Gianluca Gennari <gennarone@gmail.com>
Cc: linux-media@vger.kernel.org, m@bues.ch, hfvogt@gmx.net,
	mchehab@redhat.com
Subject: Re: [PATCH 3/5] tda18218: fix IF frequency for 7MHz bandwidth channels
Date: Tue, 03 Apr 2012 01:40:09 +0300	[thread overview]
Message-ID: <4F7A2AC9.8040407@iki.fi> (raw)
In-Reply-To: <1333401917-27203-4-git-send-email-gennarone@gmail.com>

On 03.04.2012 00:25, Gianluca Gennari wrote:
> This is necessary to tune VHF channels with the AVerMedia A835 stick.
>
> Signed-off-by: Gianluca Gennari<gennarone@gmail.com>
> ---
>   drivers/media/common/tuners/tda18218.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/common/tuners/tda18218.c b/drivers/media/common/tuners/tda18218.c
> index dfb3a83..b079696 100644
> --- a/drivers/media/common/tuners/tda18218.c
> +++ b/drivers/media/common/tuners/tda18218.c
> @@ -144,7 +144,7 @@ static int tda18218_set_params(struct dvb_frontend *fe)
>   		priv->if_frequency = 3000000;
>   	} else if (bw<= 7000000) {
>   		LP_Fc = 1;
> -		priv->if_frequency = 3500000;
> +		priv->if_frequency = 4000000;
>   	} else {
>   		LP_Fc = 2;
>   		priv->if_frequency = 4000000;

Kwaak, I will not apply that until I have done background checking. That 
driver is used only by AF9015 currently. And I did that driver as 
reverse-engineering and thus there is some things guessed. I have only 8 
MHz wide signal, thus I never tested 7 and 6 MHz. Have no DVB-T 
modulator either... Maybe some AF9015 user can confirm? Is there any 
AF9015 & TDA18218 bug reports seen in discussion forums...

regards
Antti
-- 
http://palosaari.fi/

  reply	other threads:[~2012-04-02 22:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 21:25 [PATCH 0/5] af9035: support for tda18218 tuner, new USB IDs and more Gianluca Gennari
2012-04-02 21:25 ` [PATCH 1/5] af9035: add USB id for 07ca:a867 Gianluca Gennari
2012-04-02 22:32   ` Antti Palosaari
2012-04-02 21:25 ` [PATCH 2/5] af9035: add support for the tda18218 tuner Gianluca Gennari
2012-04-02 22:33   ` Antti Palosaari
2012-04-02 21:25 ` [PATCH 3/5] tda18218: fix IF frequency for 7MHz bandwidth channels Gianluca Gennari
2012-04-02 22:40   ` Antti Palosaari [this message]
2012-04-03  0:44     ` Gianluca Gennari
2012-04-03  7:18       ` poma
2012-04-03 10:19       ` Antti Palosaari
2012-04-03 16:03         ` Gianluca Gennari
2012-04-04 13:15         ` Gianluca Gennari
2012-04-04 13:27           ` Antti Palosaari
2012-04-06 10:40             ` Gianluca Gennari
2012-04-02 21:25 ` [PATCH 4/5] af9035: fix warning Gianluca Gennari
2012-04-02 22:41   ` Antti Palosaari
2012-04-02 21:25 ` [PATCH 5/5] af9035: use module_usb_driver macro Gianluca Gennari
2012-04-02 22:42   ` Antti Palosaari
2012-04-06 20:19 ` Re : [PATCH 0/5] af9035: support for tda18218 tuner, new USB IDs and more Sril

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F7A2AC9.8040407@iki.fi \
    --to=crope@iki.fi \
    --cc=gennarone@gmail.com \
    --cc=hfvogt@gmx.net \
    --cc=linux-media@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).