From: Antti Palosaari <crope@iki.fi>
To: Hans-Frieder Vogt <hfvogt@gmx.net>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] af9033: implement ber and ucb functions
Date: Wed, 04 Apr 2012 01:30:08 +0300 [thread overview]
Message-ID: <4F7B79F0.7010707@iki.fi> (raw)
In-Reply-To: <201204032259.43658.hfvogt@gmx.net>
On 03.04.2012 23:59, Hans-Frieder Vogt wrote:
> af9033: implement read_ber and read_ucblocks functions.
>
> Signed-off-by: Hans-Frieder Vogt<hfvogt@gmx.net>
For my quick test UCB counter seems to reset every query. That is
violation of API. See http://www.kernel.org/doc/htmldocs/media.html
Do you have attenuator you can run tests yourself? It is very cheap and
useful when coding that kind of signal statistics.
Current API does not even define anymore units for BER and UCB, so those
calculations are not necessary. Anyhow, you can add some calculations if
you wish.
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-04-03 22:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 20:59 [PATCH] af9033: implement ber and ucb functions Hans-Frieder Vogt
2012-04-03 22:30 ` Antti Palosaari [this message]
2012-04-06 8:34 ` Hans-Frieder Vogt
2012-04-06 9:28 ` Antti Palosaari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7B79F0.7010707@iki.fi \
--to=crope@iki.fi \
--cc=hfvogt@gmx.net \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).