From: Chris Rankin <rankincj@yahoo.com>
To: crope@iki.fi
Cc: linux-media@vger.kernel.org
Subject: Re: DVB ioctl FE_GET_EVENT behaviour broken in 3.3
Date: Fri, 06 Apr 2012 15:59:05 +0100 [thread overview]
Message-ID: <4F7F04B9.1040802@yahoo.com> (raw)
In-Reply-To: <4F7ED7E9.203@iki.fi>
The problem is that the following line was deleted from the FE_SET_FRONTEND
ioctl logic:
fepriv->parameters_out = fepriv->parameters_in;
The following dirty little patch restores the correct behaviour:
--- dvb_frontend.c.orig 2012-04-06 13:28:43.000000000 +0100
+++ dvb_frontend.c 2012-04-06 15:42:04.000000000 +0100
@@ -1877,6 +1877,8 @@
if (c->hierarchy == HIERARCHY_NONE && c->code_rate_LP == FEC_NONE)
c->code_rate_LP = FEC_AUTO;
+ fepriv->parameters_out.frequency = c->frequency;
+
/* get frontend-specific tuning settings */
memset(&fetunesettings, 0, sizeof(struct dvb_frontend_tune_settings));
if (fe->ops.get_tune_settings && (fe->ops.get_tune_settings(fe,
&fetunesettings) == 0)) {
I'm hoping that someone out there who understands the new logic better than I
can provide a better patch.
Cheers,
Chris
next prev parent reply other threads:[~2012-04-06 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 23:00 Is xine DVB broken with Linux 3.3.1? Chris Rankin
2012-04-04 23:33 ` Chris Rankin
2012-04-06 10:49 ` DVB ioctl FE_GET_EVENT behaviour broken in 3.3 Chris Rankin
2012-04-06 11:47 ` Antti Palosaari
2012-04-06 12:06 ` Chris Rankin
2012-04-06 14:59 ` Chris Rankin [this message]
2012-04-06 20:06 ` [REGRESSION] Linux 3.3 DVB userspace ABI broken for xine (FE_SET_FRONTEND) Chris Rankin
2012-04-06 20:21 ` [PATCH] " Chris Rankin
2012-04-06 22:38 ` [PATCH v2] " Chris Rankin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7F04B9.1040802@yahoo.com \
--to=rankincj@yahoo.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).