From: Chris Rankin <rankincj@yahoo.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: [PATCH v2] Linux 3.3 DVB userspace ABI broken for xine (FE_SET_FRONTEND)
Date: Fri, 06 Apr 2012 23:38:18 +0100 [thread overview]
Message-ID: <4F7F705A.3010507@yahoo.com> (raw)
In-Reply-To: <4F7F4CAF.4010501@yahoo.com>
[-- Attachment #1: Type: text/plain, Size: 278 bytes --]
I've had a closer look at the commit which caused the regression and it looks
like there were two places where fepriv->parameters_in was assigned to
fepriv->parameters_out. So I've updated my patch accordingly.
Cheers,
Chris
Signed-off-by: Chris Rankin <rankincj@yahoo.com>
[-- Attachment #2: DVB.diff --]
[-- Type: text/x-patch, Size: 1338 bytes --]
--- linux-3.3/drivers/media/dvb/dvb-core/dvb_frontend.c.orig 2012-04-06 20:16:02.000000000 +0100
+++ linux-3.3/drivers/media/dvb/dvb-core/dvb_frontend.c 2012-04-06 23:16:03.000000000 +0100
@@ -143,6 +143,8 @@
static void dvb_frontend_wakeup(struct dvb_frontend *fe);
static int dtv_get_frontend(struct dvb_frontend *fe,
struct dvb_frontend_parameters *p_out);
+static int dtv_property_legacy_params_sync(struct dvb_frontend *fe,
+ struct dvb_frontend_parameters *p);
static bool has_get_frontend(struct dvb_frontend *fe)
{
@@ -695,6 +697,7 @@
fepriv->algo_status |= DVBFE_ALGO_SEARCH_AGAIN;
fepriv->delay = HZ / 2;
}
+ dtv_property_legacy_params_sync(fe, &fepriv->parameters_out);
fe->ops.read_status(fe, &s);
if (s != fepriv->status) {
dvb_frontend_add_event(fe, s); /* update event list */
@@ -1831,6 +1834,13 @@
return -EINVAL;
/*
+ * Initialize output parameters to match the values given by
+ * the user. FE_SET_FRONTEND triggers an initial frontend event
+ * with status = 0, which copies output parameters to userspace.
+ */
+ dtv_property_legacy_params_sync(fe, &fepriv->parameters_out);
+
+ /*
* Be sure that the bandwidth will be filled for all
* non-satellite systems, as tuners need to know what
* low pass/Nyquist half filter should be applied, in
prev parent reply other threads:[~2012-04-06 22:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 23:00 Is xine DVB broken with Linux 3.3.1? Chris Rankin
2012-04-04 23:33 ` Chris Rankin
2012-04-06 10:49 ` DVB ioctl FE_GET_EVENT behaviour broken in 3.3 Chris Rankin
2012-04-06 11:47 ` Antti Palosaari
2012-04-06 12:06 ` Chris Rankin
2012-04-06 14:59 ` Chris Rankin
2012-04-06 20:06 ` [REGRESSION] Linux 3.3 DVB userspace ABI broken for xine (FE_SET_FRONTEND) Chris Rankin
2012-04-06 20:21 ` [PATCH] " Chris Rankin
2012-04-06 22:38 ` Chris Rankin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7F705A.3010507@yahoo.com \
--to=rankincj@yahoo.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).