Re: stk webcam driver needs DMI upside down table

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 04/06/2012 06:04 PM, Gregor Jasny wrote:
> Hello,
>
> I recently received a webcam upside down report from a ASUS Z96Fm owner.
> Usually we add the USB id and DMI information to the libv4l upside down
> table. Except for webcam drivers that can flip images in hardware. By
> looking at stk-webcam.c I see both, a hflip anf vflip parameter.
>
> Some gspca drivers handle the situation by adding a DMI table to the
> webcam driver. Would this make sense for the STK driver, too?

hehe, funny I still had an upside down report for the STK driver
(for a different model laptop) on my to-do list.

WRT your question, maybe adding a dmi table to the driver makes sense,
but first we must change its behavior away from flipping the image
by default to leaving the image upright. Which should fix things for
the Z96FM laptop this thread started with, as well as for the Asus
A3H laptop for which I've a report.

If we then get bug reports after making this change, then those will be
for laptops which actually do have the sensor upside down (which I think
we will, I assume that is the reason currently the driver is flipping by
default) and we can collect dmi info from the reporters and add *those*
to a dmi table :)

So for now I'm going to send a patch upstream to change the default
to not flip.

Regards,

Hans