From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kapsi.fi ([217.30.184.167]:60348 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751730Ab2DRRoa (ORCPT ); Wed, 18 Apr 2012 13:44:30 -0400 Message-ID: <4F8EFD7B.2020901@iki.fi> Date: Wed, 18 Apr 2012 20:44:27 +0300 From: Antti Palosaari MIME-Version: 1.0 To: Thomas Mair CC: linux-media@vger.kernel.org Subject: Re: RTL28XX driver References: <4F804CDC.3030306@gmail.com> <4F85D787.2050403@iki.fi> <4F85F89A.80107@schinagl.nl> <4F85FE63.1030700@iki.fi> <4F86C66A.4010404@schinagl.nl> <4F86CE09.3080601@schinagl.nl> <4F86D4B8.8060005@iki.fi> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 18.04.2012 20:18, Thomas Mair wrote: > I have been working on the driver over the past days and been making > some progress. Right now I am stuck with a small problem that I have > no idea how to deal with. > > It seems that the fc0012 tuner supports V-Band and U-Band. To switch > between those modes a GPIO output value needs to be changed. In the > original Realtek driver this is done at the beginning of the > set_parameters callback. Is there a different callback that can be > used for this or is it ok to write a RTL2832u register from the > demodulator code? Aah, I suspect it is antenna switch or LNA GPIO. You don't say what is meaning of that GPIO... If it is FC0012 input, which I think it is not, then you should use FE callback (named as callback too) with DVB_FRONTEND_COMPONENT_TUNER param. But I suspect it is not issue. So lets introduce another solution. It is fe_ioctl_override. Use it. You will find good examples both cases using following GIT greps git grep fe_ioctl_override drivers/media git grep FRONTEND_COMPONENT Antti -- http://palosaari.fi/