From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Antti Palosaari <crope@iki.fi>
Cc: "Hans-Frieder Vogt" <hfvogt@gmx.net>,
linux-media@vger.kernel.org, "Michael Büsch" <m@bues.ch>,
"Gianluca Gennari" <gennarone@gmail.com>
Subject: Re: [PATCH] af9035: add remote control support
Date: Wed, 18 Apr 2012 18:53:39 -0300 [thread overview]
Message-ID: <4F8F37E3.1040408@redhat.com> (raw)
In-Reply-To: <4F8F2E58.7000603@iki.fi>
Em 18-04-2012 18:12, Antti Palosaari escreveu:
> On 18.04.2012 23:42, Hans-Frieder Vogt wrote:
>> Am Mittwoch, 18. April 2012 schrieb Mauro Carvalho Chehab:
>>> Em 18-04-2012 11:57, Antti Palosaari escreveu:
>>>>>> +
>>>>>> + if (af9035_config.raw_ir) {
>>>>>> + ret = af9035_rd_reg(d, EEPROM_IR_TYPE,&tmp);
>>>>
>>>> No space between x,y, IIRC checkpatch reports that.
>>
>> the only errors that checkpatch is reporting is ERROR: trailing whitespace,
>> but that seems to be normal for lines in the patch that are unchanged (I run
>> checkpatch.pl --no-tree --file ...patch).
>
> I still like idea to add one space after comma always
Me too. The above, even passing on checkpatch, is not the right CodingStyle.
Regards,
Mauro
prev parent reply other threads:[~2012-04-18 21:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-07 17:24 [PATCH] af9035: add remote control support Hans-Frieder Vogt
2012-04-18 14:17 ` Mauro Carvalho Chehab
2012-04-18 14:57 ` Antti Palosaari
2012-04-18 19:18 ` Mauro Carvalho Chehab
2012-04-18 20:42 ` Hans-Frieder Vogt
2012-04-18 20:55 ` Mauro Carvalho Chehab
2012-04-18 21:12 ` Antti Palosaari
2012-04-18 21:53 ` Mauro Carvalho Chehab [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F37E3.1040408@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=gennarone@gmail.com \
--cc=hfvogt@gmx.net \
--cc=linux-media@vger.kernel.org \
--cc=m@bues.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).