* [PATCH 1/1] s5p-fimc: media_entity_pipeline_start() may fail
@ 2012-04-22 10:44 Sakari Ailus
2012-04-26 8:43 ` Sylwester Nawrocki
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2012-04-22 10:44 UTC (permalink / raw)
To: linux-media; +Cc: s.nawrocki
Take into account media_entity_pipeline_start() may fail. This patch is
dependent on "media: Add link_validate() op to check links to the sink pad".
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
---
(Just correct Sylwester's e-mail. Sorry for the noise.)
The dependent patch is part of my pull req to Mauro here:
<URL:http://www.spinics.net/lists/linux-media/msg46296.html>
drivers/media/video/s5p-fimc/fimc-capture.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-capture.c b/drivers/media/video/s5p-fimc/fimc-capture.c
index dc18ba5..8fd8095 100644
--- a/drivers/media/video/s5p-fimc/fimc-capture.c
+++ b/drivers/media/video/s5p-fimc/fimc-capture.c
@@ -963,7 +963,9 @@ static int fimc_cap_streamon(struct file *file, void *priv,
if (fimc_capture_active(fimc))
return -EBUSY;
- media_entity_pipeline_start(&p->sensor->entity, p->pipe);
+ ret = media_entity_pipeline_start(&p->sensor->entity, p->pipe);
+ if (ret < 0)
+ return ret;
if (fimc->vid_cap.user_subdev_api) {
ret = fimc_pipeline_validate(fimc);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] s5p-fimc: media_entity_pipeline_start() may fail
2012-04-22 10:44 [PATCH 1/1] s5p-fimc: media_entity_pipeline_start() may fail Sakari Ailus
@ 2012-04-26 8:43 ` Sylwester Nawrocki
0 siblings, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2012-04-26 8:43 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media
Hi Sakari,
thank you for the patch.
On 04/22/2012 12:44 PM, Sakari Ailus wrote:
> Take into account media_entity_pipeline_start() may fail. This patch is
> dependent on "media: Add link_validate() op to check links to the sink pad".
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
I will apply it on my tree for 3.5, when your remaining patches are merged
into the media tree. I really hope they are not delayed another kernel
release.
Regards,
--
Sylwester Nawrocki
Samsung Poland R&D Center
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] s5p-fimc: media_entity_pipeline_start() may fail
@ 2012-04-22 10:43 Sakari Ailus
0 siblings, 0 replies; 3+ messages in thread
From: Sakari Ailus @ 2012-04-22 10:43 UTC (permalink / raw)
To: linux-media; +Cc: s.nawrocki
Take into account media_entity_pipeline_start() may fail. This patch is
dependent on "media: Add link_validate() op to check links to the sink pad".
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
---
The dependent patch is part of my pull req to Mauro here:
<URL:http://www.spinics.net/lists/linux-media/msg46296.html>
drivers/media/video/s5p-fimc/fimc-capture.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/s5p-fimc/fimc-capture.c b/drivers/media/video/s5p-fimc/fimc-capture.c
index dc18ba5..8fd8095 100644
--- a/drivers/media/video/s5p-fimc/fimc-capture.c
+++ b/drivers/media/video/s5p-fimc/fimc-capture.c
@@ -963,7 +963,9 @@ static int fimc_cap_streamon(struct file *file, void *priv,
if (fimc_capture_active(fimc))
return -EBUSY;
- media_entity_pipeline_start(&p->sensor->entity, p->pipe);
+ ret = media_entity_pipeline_start(&p->sensor->entity, p->pipe);
+ if (ret < 0)
+ return ret;
if (fimc->vid_cap.user_subdev_api) {
ret = fimc_pipeline_validate(fimc);
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-04-26 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-22 10:44 [PATCH 1/1] s5p-fimc: media_entity_pipeline_start() may fail Sakari Ailus
2012-04-26 8:43 ` Sylwester Nawrocki
-- strict thread matches above, loose matches on Subject: below --
2012-04-22 10:43 Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).