From: Matthias Schwarzott <zzam@gentoo.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Stefan Bauer <stefan.bauer@cs.tu-chemnitz.de>,
linux-media@vger.kernel.org
Subject: Re: [RFC] b2c2_flexcop_pci: Add suspend/resume support
Date: Fri, 27 Apr 2012 10:49:56 +0200 [thread overview]
Message-ID: <4F9A5DB4.2000804@gentoo.org> (raw)
In-Reply-To: <4F905095.5020604@redhat.com>
On 19.04.2012 19:51, Mauro Carvalho Chehab wrote:
> Hi Stefan,
>
> Em 15-04-2012 11:18, Stefan Bauer escreveu:
>> Dear linux-dvb developers, dear Matthias,
>>
>>
>> proper suspend and resume support for the b2c2_flexcop_pci driver is still missing as pointed out by these two bug reports:
>>
>> https://bugs.gentoo.org/show_bug.cgi?id=288267
>> https://bugzilla.kernel.org/show_bug.cgi?id=14394
>>
>> The first report contains a proposed patch to add suspend/resume support written by Matthias Schwarzott<zzam@gentoo.org>. I and some others (see first bug report) confirm that it's actually working.
>>
>> Behaviour without the patch: b2c2_flexcop_pci must be unloaded before suspending (means TV applications must be closed), and reloaded after resuming.
>> Behaviour with the patch: No module unloading/reloading necessary any more.
>> Known issues: TV application still needs to be closed before suspend. Otherwise the device is not functional (kaffeine shows only black screen) after resume. Reloading the module revives the device in that case.
>>
>> I'd kindly ask you to review the attached patch by Matthias and consider its upstream inclusion after the issues are sorted out. I'm more than willing to assist and test as I can.
> I don't have any b2c2 device, so I can't actually test it. on a quick lock,
> it seems sane on my eyes. In order for us to merge, we need the patch author's
> Signed-off-by.
Hi!
I do not remember exactly what were the open issues with this patch or
how they could be solved, but if you want to merge the patch as it is, I
am fine with this.
So here is my Signed-off-by:
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
Regards
Matthias
prev parent reply other threads:[~2012-04-27 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-15 14:18 [RFC] b2c2_flexcop_pci: Add suspend/resume support Stefan Bauer
2012-04-19 17:51 ` Mauro Carvalho Chehab
2012-04-27 8:49 ` Matthias Schwarzott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9A5DB4.2000804@gentoo.org \
--to=zzam@gentoo.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=stefan.bauer@cs.tu-chemnitz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).