From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "nibble.max" <nibble.max@gmail.com>
Cc: Antti Palosaari <crope@iki.fi>,
linux-media <linux-media@vger.kernel.org>,
Konstantin Dimitrov <kosio.dimitrov@gmail.com>
Subject: Re: [PATCH 1/6 v2] dvbsky, montage dvb-s/s2 TS202x tuner and M88DS3103 demodulator driver
Date: Fri, 27 Apr 2012 08:06:30 -0300 [thread overview]
Message-ID: <4F9A7DB6.8090103@redhat.com> (raw)
In-Reply-To: <201204271505580788207@gmail.com>
Em 27-04-2012 04:06, nibble.max escreveu:
> ---
> drivers/media/dvb/frontends/Kconfig | 14 +
> drivers/media/dvb/frontends/Makefile | 3 +
> drivers/media/dvb/frontends/m88ds3103.c | 1153 ++++++++++++++++++++++++++
> drivers/media/dvb/frontends/m88ds3103.h | 67 ++
> drivers/media/dvb/frontends/m88ds3103_priv.h | 413 +++++++++
> drivers/media/dvb/frontends/m88ts202x.c | 590 +++++++++++++
> drivers/media/dvb/frontends/m88ts202x.h | 63 ++
> 7 files changed, 2303 insertions(+)
> create mode 100644 drivers/media/dvb/frontends/m88ds3103.c
> create mode 100644 drivers/media/dvb/frontends/m88ds3103.h
> create mode 100644 drivers/media/dvb/frontends/m88ds3103_priv.h
> create mode 100644 drivers/media/dvb/frontends/m88ts202x.c
> create mode 100644 drivers/media/dvb/frontends/m88ts202x.h
No, this is not what we've agreed. You should, instead, take Konstantin's driver,
breaking it into two separate ones, without touching the copyrights. Then, apply
what else is needed for ds3103/ts2123.
> diff --git a/drivers/media/dvb/frontends/m88ds3103.c b/drivers/media/dvb/frontends/m88ds3103.c
> new file mode 100644
> index 0000000..392cada
> --- /dev/null
> +++ b/drivers/media/dvb/frontends/m88ds3103.c
> @@ -0,0 +1,1153 @@
> +/*
> + Montage Technology M88DS3103/3000 - DVBS/S2 Satellite demod driver
> +
> + Copyright (C) 2011 Max nibble<nibble.max@gmail.com>
Adding your copyright like that only justifies if you make significant contributions
to the code. Adding support for a new card or a new chip within the same chip family
in general don't fit on that.
If Konstantin is ok, you may, instead, add, at the bottom of the copyright list, something like:
Copyright (C) 2011 Max nibble<nibble.max@gmail.com>
- Add support for ds3103
> + Copyright (C) 2010 Montage Technology<www.montage-tech.com>
> + Fix some bug and add M88DS3103 code, M88DS3000 code based on DS3000.c.
> +
> + Copyright (C) 2009 Konstantin Dimitrov <kosio.dimitrov@gmail.com>
> +
> + Copyright (C) 2009 TurboSight.com
Regards,
Mauro
next prev parent reply other threads:[~2012-04-27 11:06 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 10:38 [PATCH 1/3] m88brs2000 DVB-S frontend and tuner module Malcolm Priestley
2012-01-26 16:56 ` Mauro Carvalho Chehab
2012-01-27 22:26 ` Malcolm Priestley
2012-04-15 15:53 ` [PATCH 1/6] m88ds3103, montage dvb-s/s2 demodulator driver nibble.max
2012-04-19 18:06 ` Mauro Carvalho Chehab
2012-04-20 8:01 ` nibble.max
2012-04-19 20:08 ` Mauro Carvalho Chehab
2012-04-20 8:01 ` nibble.max
2012-04-20 9:47 ` Antti Palosaari
2012-04-20 17:24 ` Mauro Carvalho Chehab
2012-04-21 2:45 ` nibble.max
2012-04-23 16:41 ` Antti Palosaari
2012-04-23 19:51 ` Konstantin Dimitrov
2012-04-23 21:04 ` Antti Palosaari
2012-04-27 18:44 ` Konstantin Dimitrov
2012-04-23 21:49 ` Mauro Carvalho Chehab
2012-04-27 19:01 ` Konstantin Dimitrov
2012-04-27 19:36 ` Mauro Carvalho Chehab
2012-04-27 20:37 ` Konstantin Dimitrov
2012-04-27 20:40 ` Konstantin Dimitrov
2012-04-27 20:54 ` Antti Palosaari
2012-04-27 21:01 ` Konstantin Dimitrov
2012-04-27 19:55 ` Antti Palosaari
2012-04-27 20:21 ` Konstantin Dimitrov
2012-04-27 20:42 ` Antti Palosaari
2012-04-27 21:13 ` Konstantin Dimitrov
2012-04-28 3:54 ` nibble.max
2012-04-28 9:17 ` Demod hardware pid filter implement nibble.max
2012-04-28 10:15 ` Antti Palosaari
2012-04-24 2:45 ` Re: [PATCH 1/6] m88ds3103, montage dvb-s/s2 demodulator driver nibble.max
2012-04-26 13:03 ` nibble.max
2012-04-26 13:24 ` Mauro Carvalho Chehab
2012-04-27 7:06 ` [PATCH 1/6 v2] dvbsky, montage dvb-s/s2 TS202x tuner and M88DS3103 " nibble.max
2012-04-27 11:06 ` Mauro Carvalho Chehab [this message]
2012-04-27 14:17 ` Re: [PATCH 1/6 v2] dvbsky, montage dvb-s/s2 TS202x tuner and M88DS3103demodulator driver nibble.max
2012-04-27 14:35 ` Mauro Carvalho Chehab
2012-04-27 18:03 ` Konstantin Dimitrov
2012-04-27 7:06 ` [PATCH 2/6 v2] dvbsky, dvb-s/s2 usb box nibble.max
2013-06-30 3:07 ` Fwd: " P. van Gaans
2014-01-15 19:30 ` Mauro Carvalho Chehab
2012-04-27 7:06 ` [PATCH 3/6 v2] dvbsky, dvb-s/s2 PCIe card nibble.max
2012-04-27 7:07 ` [PATCH 4/6 v2] dvbsky, dvb-s/s2 PCI card nibble.max
2012-04-27 7:07 ` [PATCH 5/6 v2] dvbsky, remote control key map nibble.max
2012-04-27 7:07 ` [PATCH 6/6 v2] dvbsky, remote control include header file nibble.max
2012-04-20 17:10 ` [PATCH 1/6] m88ds3103, montage dvb-s/s2 demodulator driver Mauro Carvalho Chehab
2012-04-15 15:53 ` [PATCH 2/6] m88ds3103, dvbsky dvb-s2 usb box nibble.max
2012-04-19 18:09 ` Mauro Carvalho Chehab
2012-04-20 8:08 ` nibble.max
2012-04-20 17:08 ` Mauro Carvalho Chehab
2012-04-15 15:53 ` [PATCH 3/6] m88ds3103, dvbsky dvb-s2 cx23883 pci card nibble.max
2012-04-15 15:53 ` [PATCH 4/6] m88ds3103, dvbsky dvb-s2 cx23885 pcie card nibble.max
2012-04-19 18:11 ` Mauro Carvalho Chehab
2012-04-15 15:53 ` [PATCH 5/6] m88ds3103, dvbsky remote control key map nibble.max
2012-04-19 18:16 ` Mauro Carvalho Chehab
2012-04-20 8:01 ` nibble.max
2012-04-15 15:53 ` [PATCH 6/6] m88ds3103, dvbsky remote control include header file nibble.max
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9A7DB6.8090103@redhat.com \
--to=mchehab@redhat.com \
--cc=crope@iki.fi \
--cc=kosio.dimitrov@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=nibble.max@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).