Re: [PATCH/RFC v3 04/14] V4L: Add camera wide dynamic range control

[Sylwester Nawrocki <snjw23@gmail.com>]

Hi Hans,

On 04/30/2012 05:54 PM, Hans Verkuil wrote:
> On Monday 30 April 2012 17:50:57 Hans Verkuil wrote:
>> On Friday 27 April 2012 16:23:21 Sylwester Nawrocki wrote:
>>> Add V4L2_CID_WIDE_DYNAMIC_RANGE camera class control for camera wide
>>> dynamic range (WDR, HDR) feature. This control has now only menu entries
>>> for enabling and disabling WDR. It can be extended when the wide dynamic
>>> range technique selection is needed.
> 
> Never mind, I get it. It's for future expansion.
> 
> That said, I find it dubious to make this an enum.
> 
> I would go with a boolean control and perhaps make a remark that it might 
> become an enum in the future if more options are needed.

Yes, my intention was to have something that would be easy to expand 
without ABI perturbations. I believe in future there may be more 
detailed control needed, than just WDR enable/disable. 

Thanks for the suggestion, I'll revert this back to a boolean type
and add proper note in the documentation.

--

Regards,
Sylwester