From: Antti Palosaari <crope@iki.fi>
To: Thomas Mair <thomas.mair86@googlemail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/5] rtl2832 ver 0.3: suport for RTL2832 demodulator revised version
Date: Sun, 13 May 2012 21:53:46 +0300 [thread overview]
Message-ID: <4FB0033A.4090104@iki.fi> (raw)
In-Reply-To: <1336846109-30070-2-git-send-email-thomas.mair86@googlemail.com>
On 12.05.2012 21:08, Thomas Mair wrote:
> Changes compared to version 0.2:
> - removed reading of signal strength for tuners FC0012,FC0013 (is now supported by fc0012,fc0013 driver)
> - moved definition of register names to rtl2832_priv.h
> - cleaned up demod private structure
> - replaced rtl2832_log2 function with intlog2 from dvb_math
>
> Signed-off-by: Thomas Mair<thomas.mair86@googlemail.com>
Testing shows UCB counter is totally broken. It does that all the time,
64 => <some number> => 64
status SCVYL | signal 2b2b | snr b08c | ber 00000024 | unc 00000064 |
FE_HAS_LOCK
status SCVYL | signal 2b2b | snr a7b8 | ber 0000007d | unc 0000005e |
FE_HAS_LOCK
status SCVYL | signal 2b2b | snr b08c | ber 0000002c | unc 00000064 |
FE_HAS_LOCK
Also other small issue. You have added new line to the log writings
provided by DVB USB. DVB USB log writing has already new line! That is
2nd time I point out line errors. Did you use some special set-up during
the development ?
May 13 21:33:06 localhost kernel: [204738.354039] rtl28xxu:
rtl2832u_frontend_attach: FC0012 tuner found
May 13 21:33:06 localhost kernel: [204738.354040]
May 13 21:33:06 localhost kernel: [204738.361304] DVB: registering
adapter 0 frontend 0 (Realtek RTL2832 (DVB-T))...
I quickly looked patches through and those looked very good. I will try
to review those tonight.
And here is whole set (tuner+rtl2832u) if someone else would like to test:
http://git.linuxtv.org/anttip/media_tree.git/shortlog/refs/heads/rtl2832u
regards
Antti
--
http://palosaari.fi/
next prev parent reply other threads:[~2012-05-13 18:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-12 18:08 [PATCH 0/5] support rtl2832 demodulator Thomas Mair
2012-05-12 18:08 ` [PATCH 1/5] rtl2832 ver 0.3: suport for RTL2832 demodulator revised version Thomas Mair
2012-05-12 22:07 ` poma
2012-05-13 18:53 ` Antti Palosaari [this message]
2012-05-13 20:56 ` Thomas Mair
2012-05-14 1:37 ` Antti Palosaari
2012-05-14 1:46 ` Antti Palosaari
2012-05-15 15:41 ` Antti Palosaari
2012-05-16 5:10 ` poma
2012-05-18 19:16 ` Antti Palosaari
2012-05-12 18:08 ` [PATCH 2/5] rtl28xxu: support for the rtl2832 demod driver Thomas Mair
2012-05-12 18:08 ` [PATCH 3/5] rtl28xxu: renamed rtl2831_rd/rtl2831_wr to rtl28xx_rd/rtl28xx_wr Thomas Mair
2012-05-12 18:08 ` [PATCH 4/5] rtl28xxu: support G-Tek Electronics Group Lifeview LV5TDLX DVB-T Thomas Mair
2012-05-12 18:08 ` [PATCH 5/5] rtl28xxu: support Terratec Noxon DAB/DAB+ stick Thomas Mair
2012-05-12 20:47 ` Thomas Mair
2012-05-13 21:18 ` [PATCH] rtl28xxu: removed newlines from info strings Thomas Mair
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB0033A.4090104@iki.fi \
--to=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=thomas.mair86@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).