From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Michael Krufky <mkrufky@kernellabs.com>
Cc: linux-media <linux-media@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Michael Krufky <mkrufky@linuxtv.org>
Subject: Re: [PATCH 02/10] DocBook: document new DTV Properties for ATSC-MH delivery system
Date: Mon, 14 May 2012 15:57:34 -0300 [thread overview]
Message-ID: <4FB1559E.4050502@redhat.com> (raw)
In-Reply-To: <1335845545-20879-2-git-send-email-mkrufky@linuxtv.org>
Em 01-05-2012 01:12, Michael Krufky escreveu:
> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Where's the patch description? For sure a patch like that deserves to be
well described.
> ---
> Documentation/DocBook/media/dvb/dvbproperty.xml | 178 +++++++++++++++++++++++
> 1 files changed, 178 insertions(+), 0 deletions(-)
>
> + </section>
> + <section id="DTV-ATSCMH-FIC-ERR">
> + <title><constant>DTV_ATSCMH_FIC_ERR</constant></title>
> + <para>FIC error count.</para>
> + <para>Possible values: 0, 1, 2, 3, ..., 0xffff</para>
> + </section>
> + <section id="DTV-ATSCMH-CRC-ERR">
> + <title><constant>DTV_ATSCMH_CRC_ERR</constant></title>
> + <para>CRC error count.</para>
> + <para>Possible values: 0, 1, 2, 3, ..., 0xffff</para>
> + </section>
> + <section id="DTV-ATSCMH-RS-ERR">
> + <title><constant>DTV_ATSCMH_RS_ERR</constant></title>
> + <para>RS error count.</para>
> + <para>Possible values: 0, 1, 2, 3, ..., 0xffff</para>
> + </section>
The above for sure belongs to statistics API. It should be addressed together
with the other statistics API bits.
We shouldn't mix statistics with DVB frontent properties.
Btw, this is basically the same case as on ISDB-T: the layer that handles the channel
data (TPC, on ATSC M/H; TPS on DVB; TMCC on ISDB) provides statistics about
the frontend. However, the DVBv3 quality ioctl's are prepared to handle only
DVB parameters, and fails with more modern delivery systems.
We should apply a patch that will fix this one for all, like the one proposed by:
http://patchwork.linuxtv.org/patch/9578/
Regards,
Mauro
next prev parent reply other threads:[~2012-05-14 18:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 4:12 [PATCH 01/10] linux-dvb v5 API support for ATSC-MH Michael Krufky
2012-05-01 4:12 ` [PATCH 02/10] DocBook: document new DTV Properties for ATSC-MH delivery system Michael Krufky
2012-05-14 18:57 ` Mauro Carvalho Chehab [this message]
2012-05-01 4:12 ` [PATCH 03/10] increment DVB API to version 5.6 for ATSC-MH frontend control Michael Krufky
2012-05-01 4:12 ` [PATCH 04/10] mxl111sf-tuner: tune SYS_ATSCMH just like SYS_ATSC Michael Krufky
2012-05-01 4:12 ` [PATCH 05/10] DVB: add support for the LG2160 ATSC-MH demodulator Michael Krufky
2012-05-01 4:12 ` [PATCH 06/10] lg2160: update internal api interfaces and enable build Michael Krufky
2012-05-01 4:12 ` [PATCH 07/10] dvb-demux: add functionality to send raw payload to the dvr device Michael Krufky
2012-05-02 11:38 ` Patrick Boettcher
2012-05-02 15:12 ` Michael Krufky
2012-05-01 4:12 ` [PATCH 08/10] dvb-usb: add support for dvb-usb-adapters that deliver raw payload Michael Krufky
2012-05-01 4:12 ` [PATCH 09/10] dvb-usb: increase MAX_NO_OF_FE_PER_ADAP from 2 to 3 Michael Krufky
2012-05-01 4:12 ` [PATCH 10/10] mxl111sf: add ATSC-MH support Michael Krufky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB1559E.4050502@redhat.com \
--to=mchehab@redhat.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mkrufky@kernellabs.com \
--cc=mkrufky@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).