Re: [GIT PULL FOR v3.5 v2] V4L2 subdev and sensor control changes and SMIA++ driver

[Mauro Carvalho Chehab <mchehab@redhat.com>]

Em 10-04-2012 16:35, Sakari Ailus escreveu:
> Hi Mauro,
> 
> This patchset adds
> 
> - Integer menu controls,
> - Selection IOCTL for subdevs,
> - Sensor control improvements,
> - link_validate() media entity and V4L2 subdev pad ops,
> - OMAP 3 ISP driver improvements,
> - SMIA++ sensor driver and
> - Other V4L2 and media improvements (see individual patches)
> 
> Changes since pull for 3.5 v1:
> 
> - Rebased on top of for_v3.5 branch --- some of the earlier patches are
>   included in that branch: integer menu and subdev selections
>   (apart from docs)
> - Fix DocBook build warnings in subdev selections and DPCM compressed raw
>   bayer pixel format documentation
> 
> Changes since pull for 3.4 v3:
> 
> - Changed kernel revision and V4L2 changelog dates appropriately for Linux
>   3.5.
> 
> Changes since pull v2:
> 
> - Fixed incorrect 4CC codes in documentation for compresed raw bayer formats
> 
> Changes since pull v1:
> 
> - Correct selection rectangle field description in subdev selection
>   documentation (thanks to Sylwester)
> - Use roundup() instead of ALIGN() in SMIA++ driver
> - Rebased on current media_tree.git/staging/for_v3.4
> 
> ---
> 
...
>  drivers/media/video/smiapp/smiapp-debug.h          |   32 +

Please get rid of this horrible file that has just:

#ifdef CONFIG_VIDEO_SMIAPP_DEBUG
#define DEBUG
#endif

There's absolutely no reason to add something as ugly as this. To make this
worse, it breaks media-build out-of-tree compilation:

/home/v4l/media_build/v4l/smiapp-pll.c:25:33: fatal error: smiapp/smiapp-debug.h: No such file or directory
compilation terminated.

Thanks!
Mauro